-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDR Workflows] Fix alert_test.cy.ts flakiness #198516
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7313[✅] Osquery - Cypress: 50/50 tests passed. |
/ci |
tomsonpl
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.16.0
backport:version
Backport to applied version labels
v8.17.0
labels
Oct 31, 2024
/ci |
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
tomsonpl
requested review from
szwarckonrad
and removed request for
ashokaditya and
parkiino
October 31, 2024 14:31
szwarckonrad
approved these changes
Oct 31, 2024
Starting backport for target branches: 8.16, 8.x |
💚 Build Succeeded
Metrics [docs]
History
cc @tomsonpl |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 04ad896)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 04ad896)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows] Fix alert_test.cy.ts flakiness (#198516)](#198516) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tomasz Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T16:16:33Z","message":"[EDR Workflows] Fix alert_test.cy.ts flakiness (#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR Workflows] Fix alert_test.cy.ts flakiness","number":198516,"url":"https://github.com/elastic/kibana/pull/198516","mergeCommit":{"message":"[EDR Workflows] Fix alert_test.cy.ts flakiness (#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198516","number":198516,"mergeCommit":{"message":"[EDR Workflows] Fix alert_test.cy.ts flakiness (#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tomasz Ciecierski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
) # Backport This will backport the following commits from `main` to `8.16`: - [[EDR Workflows] Fix alert_test.cy.ts flakiness (#198516)](#198516) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tomasz Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T16:16:33Z","message":"[EDR Workflows] Fix alert_test.cy.ts flakiness (#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR Workflows] Fix alert_test.cy.ts flakiness","number":198516,"url":"https://github.com/elastic/kibana/pull/198516","mergeCommit":{"message":"[EDR Workflows] Fix alert_test.cy.ts flakiness (#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198516","number":198516,"mergeCommit":{"message":"[EDR Workflows] Fix alert_test.cy.ts flakiness (#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tomasz Ciecierski <[email protected]>
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.16.0
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test seemed to be failing when clicking the wrong alert and doing so too quickly.
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7313