Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows] Fix alert_test.cy.ts flakiness #198516

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Oct 31, 2024

The test seemed to be failing when clicking the wrong alert and doing so too quickly.
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7313

@tomsonpl tomsonpl self-assigned this Oct 31, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7313

[✅] Osquery - Cypress: 50/50 tests passed.

see run history

@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 31, 2024
@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl marked this pull request as ready for review October 31, 2024 14:31
@tomsonpl tomsonpl requested a review from a team as a code owner October 31, 2024 14:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@tomsonpl tomsonpl requested review from szwarckonrad and removed request for ashokaditya and parkiino October 31, 2024 14:31
@tomsonpl tomsonpl enabled auto-merge (squash) October 31, 2024 14:57
@tomsonpl tomsonpl merged commit 04ad896 into elastic:main Oct 31, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11615734527

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @tomsonpl

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 31, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 31, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[EDR Workflows] Fix alert_test.cy.ts flakiness
(#198516)](#198516)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T16:16:33Z","message":"[EDR
Workflows] Fix alert_test.cy.ts flakiness
(#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR
Workflows] Fix alert_test.cy.ts
flakiness","number":198516,"url":"https://github.com/elastic/kibana/pull/198516","mergeCommit":{"message":"[EDR
Workflows] Fix alert_test.cy.ts flakiness
(#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198516","number":198516,"mergeCommit":{"message":"[EDR
Workflows] Fix alert_test.cy.ts flakiness
(#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tomasz Ciecierski <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 31, 2024
)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[EDR Workflows] Fix alert_test.cy.ts flakiness
(#198516)](#198516)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T16:16:33Z","message":"[EDR
Workflows] Fix alert_test.cy.ts flakiness
(#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR
Workflows] Fix alert_test.cy.ts
flakiness","number":198516,"url":"https://github.com/elastic/kibana/pull/198516","mergeCommit":{"message":"[EDR
Workflows] Fix alert_test.cy.ts flakiness
(#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198516","number":198516,"mergeCommit":{"message":"[EDR
Workflows] Fix alert_test.cy.ts flakiness
(#198516)","sha":"04ad8964558d98fbe8dd8788d09f30fa4bfd0b55"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tomasz Ciecierski <[email protected]>
nreese pushed a commit to nreese/kibana that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants