Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Fix invalid index management link #198499

Conversation

kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Oct 31, 2024

Summary

This PR fixes invalid URL for To modify the index, go to Index Management. link.

Closes: #125003

@kowalczyk-krzysztof kowalczyk-krzysztof added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Maps labels Oct 31, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Oct 31, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof requested review from a team as code owners October 31, 2024 11:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileUpload 951.4KB 951.4KB +13.0B

cc @kowalczyk-krzysztof

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for fixing

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 7701087 into elastic:main Oct 31, 2024
34 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11616018039

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 31, 2024
## Summary

This PR fixes invalid URL for `To modify the index, go to Index
Management.` link.

Closes: elastic#125003
(cherry picked from commit 7701087)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 31, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Maps] Fix invalid index management link
(#198499)](#198499)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T16:34:32Z","message":"[Maps]
Fix invalid index management link (#198499)\n\n## Summary\r\n\r\nThis PR
fixes invalid URL for `To modify the index, go to Index\r\nManagement.`
link.\r\n\r\nCloses:
#125003","sha":"7701087f443f57f0021fbfd71d83e4d914322426","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Presentation","release_note:skip","v9.0.0","backport:prev-minor","Feature:Maps"],"title":"[Maps]
Fix invalid index management
link","number":198499,"url":"https://github.com/elastic/kibana/pull/198499","mergeCommit":{"message":"[Maps]
Fix invalid index management link (#198499)\n\n## Summary\r\n\r\nThis PR
fixes invalid URL for `To modify the index, go to Index\r\nManagement.`
link.\r\n\r\nCloses:
#125003","sha":"7701087f443f57f0021fbfd71d83e4d914322426"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198499","number":198499,"mergeCommit":{"message":"[Maps]
Fix invalid index management link (#198499)\n\n## Summary\r\n\r\nThis PR
fixes invalid URL for `To modify the index, go to Index\r\nManagement.`
link.\r\n\r\nCloses:
#125003","sha":"7701087f443f57f0021fbfd71d83e4d914322426"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
nreese pushed a commit to nreese/kibana that referenced this pull request Nov 1, 2024
## Summary

This PR fixes invalid URL for `To modify the index, go to Index
Management.` link.

Closes: elastic#125003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.17.0 v9.0.0
Projects
None yet
4 participants