Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [CI] Quiet quickcheck i18n output (#197871) #198473

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[8.x] [CI] Quiet quickcheck i18n output (#197871) #198473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/scripts/steps/checks/i18n.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ set -euo pipefail
source .buildkite/scripts/common/util.sh

echo --- Check i18n
node scripts/i18n_check
node scripts/i18n_check --quiet
18 changes: 9 additions & 9 deletions src/dev/i18n_tools/bin/run_i18n_check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import { Listr } from 'listr2';
import { run } from '@kbn/dev-cli-runner';
import { ToolingLog } from '@kbn/tooling-log';
import { getTimeReporter } from '@kbn/ci-stats-reporter';
import { isFailError } from '@kbn/dev-cli-errors';
import { I18nCheckTaskContext, MessageDescriptor } from '../types';
Expand All @@ -24,13 +23,7 @@ import {
import { TaskReporter } from '../utils/task_reporter';
import { flagFailError, isDefined, undefinedOrBoolean } from '../utils/verify_bin_flags';

const toolingLog = new ToolingLog({
level: 'info',
writeTo: process.stdout,
});

const runStartTime = Date.now();
const reportTime = getTimeReporter(toolingLog, 'scripts/i18n_check');

const skipOnNoTranslations = ({ config }: I18nCheckTaskContext) =>
!config?.translations.length && 'No translations found.';
Expand All @@ -50,9 +43,13 @@ run(
namespace: namespace,
fix = false,
path,
silent,
quiet,
},
log,
}) => {
const reportTime = getTimeReporter(log, 'scripts/i18n_check');

if (
fix &&
(isDefined(ignoreIncompatible) ||
Expand Down Expand Up @@ -131,13 +128,15 @@ run(
{
concurrent: false,
exitOnError: true,
renderer: process.env.CI ? 'verbose' : ('default' as any),
forceTTY: false,
renderer:
((silent || quiet) && 'silent') || (process.env.CI ? 'verbose' : ('default' as any)),
}
);

try {
const messages: Map<string, MessageDescriptor[]> = new Map();
const taskReporter = new TaskReporter({ toolingLog });
const taskReporter = new TaskReporter({ toolingLog: log });
await list.run({ messages, taskReporter });

reportTime(runStartTime, 'total', {
Expand All @@ -150,6 +149,7 @@ run(
reportTime(runStartTime, 'error', {
success: false,
});
log.error(error);
} else {
log.error('Unhandled exception!');
log.error(error);
Expand Down