Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [ML] Fix overall bucket request for large number of job IDs (#198292) #198415

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…198292)

## Summary

Fixes elastic#190591

Adds chunking for `over_buckets` request to prevent exceeding the
request length URL.

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit fa0f397)
@kibanamachine kibanamachine merged commit 318831e into elastic:8.16 Oct 30, 2024
25 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 75.3KB 75.5KB +180.0B

cc @darnautov

kibanamachine added a commit that referenced this pull request Oct 31, 2024
…98292) (#198485)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Fix overall bucket request for large number of job IDs
(#198292)](#198292)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T17:30:16Z","message":"[ML]
Fix overall bucket request for large number of job IDs (#198292)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for
`over_buckets` request to prevent exceeding the\r\nrequest length
URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
Fix overall bucket request for large number of job
IDs","number":198292,"url":"https://github.com/elastic/kibana/pull/198292","mergeCommit":{"message":"[ML]
Fix overall bucket request for large number of job IDs (#198292)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for
`over_buckets` request to prevent exceeding the\r\nrequest length
URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198292","number":198292,"mergeCommit":{"message":"[ML]
Fix overall bucket request for large number of job IDs (#198292)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for
`over_buckets` request to prevent exceeding the\r\nrequest length
URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198415","number":198415,"state":"MERGED","mergeCommit":{"sha":"318831e20a039ec3d41d12108a85ced5064116d7","message":"[8.16]
[ML] Fix overall bucket request for large number of job IDs (#198292)
(#198415)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.16`:\n- [[ML] Fix overall bucket request for large number
of job
IDs\n(#198292)](https://github.com/elastic/kibana/pull/198292)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Dima\nArnautov\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-30T17:30:16Z\",\"message\":\"[ML]\nFix
overall bucket request for large number of job IDs
(#198292)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/190591\\r\\n\\r\\nAdds
chunking for\n`over_buckets` request to prevent exceeding
the\\r\\nrequest length\nURL.\\r\\n\\r\\n###
Checklist\\r\\n\\r\\n\\r\\n- [ ] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most
common\nscenarios\",\"sha\":\"fa0f397a4269a37370d2101a8c5ece03ad0117bd\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\":ml\",\"v9.0.0\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]\nFix
overall bucket request for large number of
job\nIDs\",\"number\":198292,\"url\":\"https://github.com/elastic/kibana/pull/198292\",\"mergeCommit\":{\"message\":\"[ML]\nFix
overall bucket request for large number of job IDs
(#198292)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/190591\\r\\n\\r\\nAdds
chunking for\n`over_buckets` request to prevent exceeding
the\\r\\nrequest length\nURL.\\r\\n\\r\\n###
Checklist\\r\\n\\r\\n\\r\\n- [ ] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most
common\nscenarios\",\"sha\":\"fa0f397a4269a37370d2101a8c5ece03ad0117bd\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198292\",\"number\":198292,\"mergeCommit\":{\"message\":\"[ML]\nFix
overall bucket request for large number of job IDs
(#198292)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/190591\\r\\n\\r\\nAdds
chunking for\n`over_buckets` request to prevent exceeding
the\\r\\nrequest length\nURL.\\r\\n\\r\\n###
Checklist\\r\\n\\r\\n\\r\\n- [ ] [Unit
or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated
or added to match the most
common\nscenarios\",\"sha\":\"fa0f397a4269a37370d2101a8c5ece03ad0117bd\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Dima Arnautov
<[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants