[SecuritySolution] Fix styling issues for visualizations #198410
Merged
+12
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
changed the title
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
machadoum
approved these changes
Oct 31, 2024
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2024
) ## Summary Fixes: elastic#198370 **Before** - The was an unexpected outline for each visualization.  **After** - Overriding the style to avoid unexpected styling changed. <img width="2555" alt="Screenshot 2024-10-30 at 17 28 38" src="https://github.com/user-attachments/assets/3116a798-c859-4543-a732-ebf1ff556c68"> https://github.com/user-attachments/assets/b19ec64e-1fa0-475a-9c14-9c0e237b8f95 (cherry picked from commit 494a1df)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2024
…) (#198704) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Fix styling issues for visualizations (#198410)](#198410) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T16:45:16Z","message":"[SecuritySolution] Fix styling issues for visualizations (#198410)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/198370\r\n\r\n**Before** - The was an unexpected outline for each visualization.\r\n\r\n\r\n\r\n**After** - Overriding the style to avoid unexpected styling changed.\r\n\r\n<img width=\"2555\" alt=\"Screenshot 2024-10-30 at 17 28 38\"\r\nsrc=\"https://github.com/user-attachments/assets/3116a798-c859-4543-a732-ebf1ff556c68\">\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b19ec64e-1fa0-475a-9c14-9c0e237b8f95","sha":"494a1dfed36ea7cb7b050e833ecfacb6bda21a85","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","v9.0.0","Team:Threat Hunting:Explore","v8.17.0"],"title":"[SecuritySolution] Fix styling issues for visualizations","number":198410,"url":"https://github.com/elastic/kibana/pull/198410","mergeCommit":{"message":"[SecuritySolution] Fix styling issues for visualizations (#198410)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/198370\r\n\r\n**Before** - The was an unexpected outline for each visualization.\r\n\r\n\r\n\r\n**After** - Overriding the style to avoid unexpected styling changed.\r\n\r\n<img width=\"2555\" alt=\"Screenshot 2024-10-30 at 17 28 38\"\r\nsrc=\"https://github.com/user-attachments/assets/3116a798-c859-4543-a732-ebf1ff556c68\">\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b19ec64e-1fa0-475a-9c14-9c0e237b8f95","sha":"494a1dfed36ea7cb7b050e833ecfacb6bda21a85"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198410","number":198410,"mergeCommit":{"message":"[SecuritySolution] Fix styling issues for visualizations (#198410)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/198370\r\n\r\n**Before** - The was an unexpected outline for each visualization.\r\n\r\n\r\n\r\n**After** - Overriding the style to avoid unexpected styling changed.\r\n\r\n<img width=\"2555\" alt=\"Screenshot 2024-10-30 at 17 28 38\"\r\nsrc=\"https://github.com/user-attachments/assets/3116a798-c859-4543-a732-ebf1ff556c68\">\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b19ec64e-1fa0-475a-9c14-9c0e237b8f95","sha":"494a1dfed36ea7cb7b050e833ecfacb6bda21a85"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Angela Chuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #198370
Before - The was an unexpected outline for each visualization.
After - Overriding the style to avoid unexpected styling changed.
Screen.Recording.2024-10-30.at.18.26.32.mov