Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [SLO] Overview embeddable chart use proper theme !! (#198299) #198406

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[8.x] [SLO] Overview embeddable chart use proper theme !! (#198299) #198406

merged 1 commit into from
Oct 30, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@shahzad31
[SLO] Overview embeddable chart use proper theme !! (elastic#198299)
bcb86ac 
## Summary

Fixes elastic#198298

Overview embeddable chart use proper theme !!

### After
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff">

### Before

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a">

(cherry picked from commit 56825f1)
@kibanamachine kibanamachine requested a review from a team as a code owner October 30, 2024 16:31
@kibanamachine kibanamachine enabled auto-merge (squash) October 30, 2024 16:31
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Oct 30, 2024
@kibanamachine kibanamachine mentioned this pull request Oct 30, 2024
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine merged commit 46b29a0 into elastic:8.x Oct 30, 2024
37 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 855.5KB 855.8KB +264.0B

cc @shahzad31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@shahzad31 shahzad31

Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @shahzad31