Fix flaky connector adapters test #198396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
cc @mikecote |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7307[✅] x-pack/test/alerting_api_integration/security_and_spaces/group4/config_non_dedicated_task_runner.ts: 100/100 tests passed. |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
Resolves elastic#198388 In this PR, I'm increasing the rule frequency to avoid rule actions running multiple times when asserting for the action to only have ran once. Flaky test runner: - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7307 (cherry picked from commit 14fa363)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fix flaky connector adapters test (#198396)](#198396) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mike Côté","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T13:53:55Z","message":"Fix flaky connector adapters test (#198396)\n\nResolves https://github.com/elastic/kibana/issues/198388\r\n\r\nIn this PR, I'm increasing the rule frequency to avoid rule actions\r\nrunning multiple times when asserting for the action to only have ran\r\nonce.\r\n\r\nFlaky test runner:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7307","sha":"14fa363053f43ca71466e0eaad717296f86561c7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Actions","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.17.0"],"title":"Fix flaky connector adapters test","number":198396,"url":"https://github.com/elastic/kibana/pull/198396","mergeCommit":{"message":"Fix flaky connector adapters test (#198396)\n\nResolves https://github.com/elastic/kibana/issues/198388\r\n\r\nIn this PR, I'm increasing the rule frequency to avoid rule actions\r\nrunning multiple times when asserting for the action to only have ran\r\nonce.\r\n\r\nFlaky test runner:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7307","sha":"14fa363053f43ca71466e0eaad717296f86561c7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198396","number":198396,"mergeCommit":{"message":"Fix flaky connector adapters test (#198396)\n\nResolves https://github.com/elastic/kibana/issues/198388\r\n\r\nIn this PR, I'm increasing the rule frequency to avoid rule actions\r\nrunning multiple times when asserting for the action to only have ran\r\nonce.\r\n\r\nFlaky test runner:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7307","sha":"14fa363053f43ca71466e0eaad717296f86561c7"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mike Côté <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #198388
In this PR, I'm increasing the rule frequency to avoid rule actions running multiple times when asserting for the action to only have ran once.
Flaky test runner: