New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Dashboard/Markdown] Add tabindex (#197848) #198394

Merged

kibanamachine merged 1 commit into elastic:8.x from kibanamachine:backport/8.x/pr-197848

Oct 30, 2024

Contributor

kibanamachine commented Oct 30, 2024

Backport

This will backport the following commits from main to 8.x:

[Dashboard/Markdown] Add tabindex (#197848)

Questions ?

Please refer to the Backport tool documentation


          [Dashboard/Markdown] Add tabindex (elastic#197848)

63c19fd

## Summary

This PR adds `tabIndex` to
[markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f).

Closes: elastic#186559

## Visuals:

https://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f

This video demonstrates the markdown panel being tabbable and the
scrollbar in being controlled with keyboard.

(cherry picked from commit 6cc8b97)

kibanamachine requested a review from a team as a code owner

October 30, 2024 15:58

kibanamachine assigned kowalczyk-krzysztof

kibanamachine added the backport label

kibanamachine enabled auto-merge (squash)

October 30, 2024 15:58

kibanamachine mentioned this pull request

[Dashboard/Markdown] Add tabindex #197848

Merged

github-actions bot approved these changes

View reviewed changes

kibanamachine merged commit f6d2608 into elastic:8.x

24 checks passed

Contributor

elasticmachine commented Oct 30, 2024

💚 Build Succeeded

Buildkite Build
Commit: 63c19fd

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeMarkdown`	5.8KB	5.8KB	+11.0B

cc @kowalczyk-krzysztof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels