Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Overview embeddable chart use proper theme !! #198299

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[SLO] Overview embeddable chart use proper theme !! #198299

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acc4540
us proper theme
shahzad31 Oct 30, 2024
1973d21
handle scrolling
shahzad31 Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...k/plugins/observability_solution/slo/public/embeddable/slo/overview/slo_overview_grid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import React from 'react';
import { ALL_VALUE, HistoricalSummaryResponse, SLOWithSummaryResponse } from '@kbn/slo-schema';
import {
Chart,
DARK_THEME,
isMetricElementEvent,
Metric,
MetricTrendShape,
Expand Down Expand Up @@ -77,8 +76,11 @@ export function SloCardChartList({ sloId }: { sloId: string }) {
const {
http: { basePath },
uiSettings,
charts,
} = useKibana().services;

const baseTheme = charts.theme.useChartsBaseTheme();

const [selectedSlo, setSelectedSlo] = React.useState<SLOWithSummaryResponse | null>(null);

const kqlQuery = `slo.id:"${sloId}"`;
Expand Down Expand Up @@ -156,7 +158,7 @@ export function SloCardChartList({ sloId }: { sloId: string }) {
<div data-shared-item="" style={{ width: '100%' }}>
<Chart>
<Settings
baseTheme={DARK_THEME}
baseTheme={baseTheme}
onElementClick={([d]) => {
if (isMetricElementEvent(d)) {
const { columnIndex, rowIndex } = d;
Expand Down