[Entity Analytics] [Entity Store] Show errors on entity store enablement #198263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiansivive
added
release_note:skip
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
jloleysens
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Hey @tiansivive ! Overall looks good. Focussed review on SO parts and left some qs.
| }, | ||
| { | ||
| type: 'data_backfill', | ||
| backfillFn: (document) => { |
There was a problem hiding this comment.
If you are adding a new default field to the schema that is optional we don't need to run this backfill operation, leaving it undefined should be fine. Or does null mean something specific in this case?
There was a problem hiding this comment.
no, it was meant to clearly state there was no value as its optional. I wasn't sure whether just leaving it undefined would work. I'll update
Comment on lines
33
to
35
| error: { | ||
| type: 'object', | ||
| }, |
There was a problem hiding this comment.
Are we searching over this value? If not then we don't need to include it in mappings.
There was a problem hiding this comment.
so I dont need to add a migration for it? I can just "silently" add it to the saved object?
There was a problem hiding this comment.
I ended up removing the migration, seems like that is the correct way to do this since we never want to search on errors. Please do let me know if there are other concerns wrt the SO @jloleysens
machadoum
reviewed
Oct 30, 2024
...ity_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
Outdated
Show resolved
Hide resolved
...ity_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
Outdated
Show resolved
Hide resolved
...ity_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
Outdated
Show resolved
Hide resolved
...ugins/security_solution/server/lib/entity_analytics/entity_store/entity_store_data_client.ts
Outdated
Show resolved
Hide resolved
...security_solution/server/lib/entity_analytics/entity_store/saved_object/engine_descriptor.ts
Outdated
Show resolved
Hide resolved
tiansivive
force-pushed
the
ea-entity-store-10900
branch
from
b5a88c1 to
29b6fea
Compare
… src/core/server/integration_tests/ci_checks'
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
jaredburgettelastic
approved these changes
Oct 31, 2024
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
…ent (elastic#198263) ## Summary This PR adds user feedback for errors that happen when enabling the entity store. Any errors during the async setup of store resources will show up as toasts, whist initial INIT request failures will appear as an error callout.   --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 4538481)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
tiansivive
added a commit
to tiansivive/kibana
that referenced
this pull request
Oct 31, 2024
…ent (elastic#198263) ## Summary This PR adds user feedback for errors that happen when enabling the entity store. Any errors during the async setup of store resources will show up as toasts, whist initial INIT request failures will appear as an error callout.   --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 4538481) # Conflicts: # oas_docs/output/kibana.serverless.yaml
tiansivive
added a commit
to tiansivive/kibana
that referenced
this pull request
Oct 31, 2024
…ent (elastic#198263) ## Summary This PR adds user feedback for errors that happen when enabling the entity store. Any errors during the async setup of store resources will show up as toasts, whist initial INIT request failures will appear as an error callout.   --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 4538481) # Conflicts: # oas_docs/output/kibana.serverless.yaml
tiansivive
added a commit
that referenced
this pull request
Oct 31, 2024
…nablement (#198263) (#198474) # Backport This will backport the following commits from `main` to `8.x`: - [Entity Analytics] [Entity Store] Show errors on entity store enablement (#198263) (4538481) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Vila Verde","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T03:44:43Z","message":"[Entity Analytics] [Entity Store] Show errors on entity store enablement (#198263)\n\n## Summary\r\n\r\nThis PR adds user feedback for errors that happen when enabling the\r\nentity store.\r\nAny errors during the async setup of store resources will show up as\r\ntoasts, whist initial INIT request failures will appear as an error\r\ncallout.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"4538481be0c7f519fe716cca611b2ebfa5f89351"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}] BACKPORT-->
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
…enablement (#198263) (#198462) # Backport This will backport the following commits from `main` to `8.16`: - [[Entity Analytics] [Entity Store] Show errors on entity store enablement (#198263)](#198263) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Vila Verde","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T03:44:43Z","message":"[Entity Analytics] [Entity Store] Show errors on entity store enablement (#198263)\n\n## Summary\r\n\r\nThis PR adds user feedback for errors that happen when enabling the\r\nentity store.\r\nAny errors during the async setup of store resources will show up as\r\ntoasts, whist initial INIT request failures will appear as an error\r\ncallout.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"4538481be0c7f519fe716cca611b2ebfa5f89351","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Theme: entity_analytics","Team:Entity Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[Entity Analytics] [Entity Store] Show errors on entity store enablement","number":198263,"url":"https://github.com/elastic/kibana/pull/198263","mergeCommit":{"message":"[Entity Analytics] [Entity Store] Show errors on entity store enablement (#198263)\n\n## Summary\r\n\r\nThis PR adds user feedback for errors that happen when enabling the\r\nentity store.\r\nAny errors during the async setup of store resources will show up as\r\ntoasts, whist initial INIT request failures will appear as an error\r\ncallout.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"4538481be0c7f519fe716cca611b2ebfa5f89351"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198263","number":198263,"mergeCommit":{"message":"[Entity Analytics] [Entity Store] Show errors on entity store enablement (#198263)\n\n## Summary\r\n\r\nThis PR adds user feedback for errors that happen when enabling the\r\nentity store.\r\nAny errors during the async setup of store resources will show up as\r\ntoasts, whist initial INIT request failures will appear as an error\r\ncallout.\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"4538481be0c7f519fe716cca611b2ebfa5f89351"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Tiago Vila Verde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds user feedback for errors that happen when enabling the entity store.
Any errors during the async setup of store resources will show up as toasts, whist initial INIT request failures will appear as an error callout.