[Infra] API tests deployment agnostic #198257

crespocarlos · 2024-10-30T08:44:07Z

closes #198015

Summary

Migrate most of the infra APIs integration tests to the deployment-agnostic approach.

Important

Metrics UI related tests were note migrated because the feature is not enabled on serverless.
Host with active alerts test was not migrated because es_archiver fails to load the alerts data. This is because on serverless, the alerts indices are created as managed data streams and that causes the es_archiver to fail. We should probably try use synthtrace.

Tested against MKI
Tested against stateful

…fix'

crespocarlos · 2024-10-30T14:10:45Z

@elasticmachine merge upstream

crespocarlos · 2024-11-01T13:33:18Z

/ci

crespocarlos · 2024-11-01T14:55:38Z

@elasticmachine merge upstream

crespocarlos · 2024-11-01T18:11:20Z

/ci

crespocarlos · 2024-11-04T08:28:01Z

x-pack/test/api_integration/deployment_agnostic/apis/observability/infra/sources.ts

+    describe('GET /api/metrics/source/{sourceId}', () => {
+      it('should just work', async () => {
+        const { body } = await supertestWithAdminScope
+          .get('/api/metrics/source/default')
          .set('kbn-xsrf', 'xxx')
-          .send({ name: 'NAME', anomalyThreshold: 20 })
          .expect(200);

-        await supertest
-          .patch(`${SOURCE_API_URL}/${SOURCE_ID}`)
-          .set('kbn-xsrf', 'xxx')
-          .send({ anomalyThreshold: -2 })
-          .expect(400);
-        await supertest
-          .patch(`${SOURCE_API_URL}/${SOURCE_ID}`)
-          .set('kbn-xsrf', 'xxx')
-          .send({ anomalyThreshold: 101 })
-          .expect(400);
+        expect(body).to.have.property('source');
+        expect(body?.source.configuration.metricAlias).to.equal('metrics-*,metricbeat-*');
+        expect(body?.source).to.have.property('status');
+        expect(body?.source.status?.metricIndicesExist).to.equal(true);
+      });
+    });
+
+    describe('GET /api/metrics/source/{sourceId}/hasData', () => {
+      it('should just work', async () => {
+        const { body } = await supertestWithAdminScope
+          .get(`/api/metrics/source/default/hasData`)
+
+          .expect(200);
+
+        expect(body).to.have.property('hasData');
+        expect(body?.hasData).to.be(true);
      });
    });


merged with http_source.ts

crespocarlos · 2024-11-04T08:28:46Z

x-pack/test/api_integration/apis/metrics_ui/metric_threshold_alert.ts

@@ -1341,5 +1344,119 @@ export default function ({ getService }: FtrProviderContext) {
        });
      });
    });
+    describe('getElasticsearchMetricQuery', () => {


Merged with metrics_alerting.ts

github-actions · 2024-11-04T08:35:49Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

dmlemeshko

Great work! LGTM

cauemarcondes

LGTM

crespocarlos · 2024-11-04T10:02:13Z

@elasticmachine merge upstream

elasticmachine · 2024-11-04T10:02:15Z

There are no new commits on the base branch.

crespocarlos · 2024-11-04T11:09:25Z

@elasticmachine merge upstream

crespocarlos · 2024-11-04T13:47:03Z

@elasticmachine merge upstream

elasticmachine · 2024-11-04T14:46:34Z

💚 Build Succeeded

Buildkite Build
Commit: c567ce1
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198257-c567ce102932

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/apm-synthtrace`	86	87	+1

Unknown metric groups

API count

id	before	after	diff
`@kbn/apm-synthtrace`	86	87	+1

History

💔 Build #247982 failed d882d2d
💔 Build #247908 failed 39eed74
💚 Build #247817 succeeded c064259
💔 Build #247765 failed efe6a2e
💔 Build #247720 failed 865ad7a

weltenwort

Logs UI test changes LGTM, thank you!

michaelolo24 · 2024-11-05T17:51:35Z

x-pack/test_serverless/api_integration/test_suites/observability/config.feature_flags.ts

@@ -21,7 +21,6 @@ export default createTestConfig({
  services,
  // add feature flags
  kbnServerArgs: [
-    '--xpack.infra.enabled=true',


Giving the 👍🏾 as I'm not sure why security solution is a code owner for an observability file? @crespocarlos .

I guess we need to change this https://github.com/crespocarlos/kibana/blob/main/.github/CODEOWNERS#L1625

kibanamachine · 2024-11-05T18:40:20Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11690507433

kibanamachine · 2024-11-05T18:45:06Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 198257

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2024-11-06T18:48:59Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 198257 locally

closes [elastic#198015](elastic#198015) ## Summary Migrate most of the infra APIs integration tests to the deployment-agnostic approach. >[!important] > - Metrics UI related tests were note migrated because the feature is not enabled on serverless. > - `Host with active alerts` test was not migrated because `es_archiver` fails to load the alerts data. This is because on serverless, the alerts indices are created as managed data streams and that causes the `es_archiver` to fail. We should probably try use synthtrace. - [x] Tested against MKI - [x] Tested against stateful --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

kibanamachine · 2024-11-07T19:48:45Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 198257 locally

kibanamachine · 2024-11-08T19:48:55Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 198257 locally

closes [elastic#198015](elastic#198015) ## Summary Migrate most of the infra APIs integration tests to the deployment-agnostic approach. >[!important] > - Metrics UI related tests were note migrated because the feature is not enabled on serverless. > - `Host with active alerts` test was not migrated because `es_archiver` fails to load the alerts data. This is because on serverless, the alerts indices are created as managed data streams and that causes the `es_archiver` to fail. We should probably try use synthtrace. - [x] Tested against MKI - [x] Tested against stateful --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 26f24c6) # Conflicts: # .github/CODEOWNERS # packages/kbn-apm-synthtrace/src/lib/apm/client/apm_synthtrace_kibana_client.ts # x-pack/test_serverless/api_integration/test_suites/observability/config.feature_flags.ts # x-pack/test_serverless/api_integration/test_suites/observability/index.feature_flags.ts # x-pack/test_serverless/tsconfig.json

# Backport This will backport the following commits from `main` to `8.x`: - [[Infra] API tests deployment agnostic (#198257)](#198257)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  --------- Co-authored-by: kibanamachine <[email protected]>

crespocarlos and others added 2 commits October 29, 2024 17:51

Make infra API tests deployment agnostic

f6567f4

Merge branch 'elastic:main' into 198015-infra-api-tests-agnostic

34abddb

crespocarlos changed the title ~~198015 infra api tests agnostic~~ [Infra] API tests deployment agnostic Oct 30, 2024

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

b1327a8

…fix'

crespocarlos force-pushed the 198015-infra-api-tests-agnostic branch 2 times, most recently from 8df3c3f to 69efed3 Compare October 30, 2024 11:09

Move metrics_ui tests out of deployment_agnostic folder

6701b34

crespocarlos force-pushed the 198015-infra-api-tests-agnostic branch from 69efed3 to 6701b34 Compare October 30, 2024 11:14

crespocarlos added 2 commits October 30, 2024 13:22

Revert apm_synthtrace_kibana_client service changes

4e961d6

Remove alias from mapping

e8c5849

elasticmachine and others added 4 commits October 30, 2024 15:10

Merge branch 'main' into 198015-infra-api-tests-agnostic

b038dee

Remove apm.alerts index mapping

6f59251

Clean up

0ecfc21

Attempt to fix existing alias error

1236ef1

crespocarlos force-pushed the 198015-infra-api-tests-agnostic branch 3 times, most recently from 843e154 to 865ad7a Compare November 1, 2024 10:40

Revert es_archive changes and split infra tests

efe6a2e

crespocarlos force-pushed the 198015-infra-api-tests-agnostic branch from 865ad7a to efe6a2e Compare November 1, 2024 13:33

elasticmachine and others added 2 commits November 1, 2024 15:55

Merge branch 'main' into 198015-infra-api-tests-agnostic

9d4c7a8

Synthtrace adjustments

c064259

crespocarlos commented Nov 4, 2024

View reviewed changes

crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 4, 2024

dmlemeshko approved these changes Nov 4, 2024

View reviewed changes

cauemarcondes approved these changes Nov 4, 2024

View reviewed changes

Merge branch 'main' into 198015-infra-api-tests-agnostic

d882d2d

Merge branch 'main' into 198015-infra-api-tests-agnostic

c567ce1

maryam-saeidi mentioned this pull request Nov 5, 2024

Migrate Custom threshold duplicated tests to the deployment agnostic framework #198691

Merged

1 task

weltenwort self-requested a review November 5, 2024 15:26

weltenwort approved these changes Nov 5, 2024

View reviewed changes

michaelolo24 reviewed Nov 5, 2024

View reviewed changes

michaelolo24 approved these changes Nov 5, 2024

View reviewed changes

crespocarlos merged commit 26f24c6 into elastic:main Nov 5, 2024
25 checks passed

crespocarlos deleted the 198015-infra-api-tests-agnostic branch November 5, 2024 18:40

kibanamachine added the v9.0.0 label Nov 5, 2024

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 6, 2024

crespocarlos mentioned this pull request Nov 11, 2024

[8.x] [Infra] API tests deployment agnostic (#198257) #199597

Merged

kibanamachine added v8.17.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infra] API tests deployment agnostic #198257

[Infra] API tests deployment agnostic #198257

crespocarlos commented Oct 30, 2024 •

edited by kibanamachine

Loading

crespocarlos commented Oct 30, 2024

crespocarlos commented Nov 1, 2024

crespocarlos commented Nov 1, 2024

crespocarlos commented Nov 1, 2024

crespocarlos Nov 4, 2024 •

edited

Loading

crespocarlos Nov 4, 2024

github-actions bot commented Nov 4, 2024

dmlemeshko left a comment

cauemarcondes left a comment

crespocarlos commented Nov 4, 2024

elasticmachine commented Nov 4, 2024

crespocarlos commented Nov 4, 2024

crespocarlos commented Nov 4, 2024

elasticmachine commented Nov 4, 2024 •

edited

Loading

API count

weltenwort left a comment

michaelolo24 Nov 5, 2024

crespocarlos Nov 5, 2024

kibanamachine commented Nov 5, 2024

kibanamachine commented Nov 5, 2024

kibanamachine commented Nov 6, 2024

kibanamachine commented Nov 7, 2024

kibanamachine commented Nov 8, 2024

[Infra] API tests deployment agnostic #198257

[Infra] API tests deployment agnostic #198257

Conversation

crespocarlos commented Oct 30, 2024 • edited by kibanamachine Loading

Summary

crespocarlos commented Oct 30, 2024

crespocarlos commented Nov 1, 2024

crespocarlos commented Nov 1, 2024

crespocarlos commented Nov 1, 2024

crespocarlos Nov 4, 2024 • edited Loading

Choose a reason for hiding this comment

crespocarlos Nov 4, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2024

🤖 GitHub comments

dmlemeshko left a comment

Choose a reason for hiding this comment

cauemarcondes left a comment

Choose a reason for hiding this comment

crespocarlos commented Nov 4, 2024

elasticmachine commented Nov 4, 2024

crespocarlos commented Nov 4, 2024

crespocarlos commented Nov 4, 2024

elasticmachine commented Nov 4, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

API count

History

weltenwort left a comment

Choose a reason for hiding this comment

michaelolo24 Nov 5, 2024

Choose a reason for hiding this comment

crespocarlos Nov 5, 2024

Choose a reason for hiding this comment

kibanamachine commented Nov 5, 2024

kibanamachine commented Nov 5, 2024

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Nov 6, 2024

kibanamachine commented Nov 7, 2024

kibanamachine commented Nov 8, 2024

crespocarlos commented Oct 30, 2024 •

edited by kibanamachine

Loading

crespocarlos Nov 4, 2024 •

edited

Loading

elasticmachine commented Nov 4, 2024 •

edited

Loading