-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] separate STATS
autocomplete routine
#198224
Merged
drewdaemon
merged 21 commits into
elastic:main
from
drewdaemon:195418/separate-autocomplete-routines-2
Nov 1, 2024
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d78642e
move sort routine to command definition
drewdaemon 9bbd6f6
make the separation between the legacy and new paths clearer
drewdaemon 3271c79
keep
drewdaemon 1723f4d
separate command autocomplete routines
drewdaemon f19de39
give command AST node to autocomplete routine
drewdaemon dea0546
handle new expression case
drewdaemon d4dfe34
rename getFieldsFor to getColumnsFor
drewdaemon 88e9226
separate DROP
drewdaemon 7ade691
Merge branch 'main' of github.com:elastic/kibana into 195418/separate…
drewdaemon e5ecfe5
first stab at STATS
drewdaemon 3df44e8
separate out util
drewdaemon e4289dd
fix field suggestions
drewdaemon 402105f
create unified function suggestion routine
drewdaemon e412687
assignment suggestion
drewdaemon 3bb659d
fix function suggestions
drewdaemon d69963c
handle assignments
drewdaemon 514c082
fix stats behavior
drewdaemon a8d2c25
make exception only for stats
drewdaemon de7d634
restore preferences behavior
drewdaemon 46cf8aa
add deprecation comment
drewdaemon 0e0f7d2
Merge branch 'main' into 195418/separate-autocomplete-routines-2
stratoula File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think we want this. A user will create an eval variable to use it in stats. Is a very common scenario. Think about date buckets or variables with case.
All the other decisions seem ok to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stratoula
Just to make sure I understand—
STATS /
STATS … BY /
Is that what you are saying?
From what I can see, this is no change in behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synced offline, I misunderstood the behavior described. We are good