Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Search][Connectors] Confirmation modal before leaving the connector creation flow (#197646) #198222

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…creation flow (elastic#197646)

## Summary

This PR shows a confirmation modal when users leave the connectors
creation flow before providing all necessary info, asking for
intentional confirmation after leaving the experience.

Setting `isFormDirty = true` only after generating the connectors config
and letting users leave the experience setting `isFormDirty = false`
when we arrive to the Finish up step

![CleanShot 2024-10-24 at 18 56
11](https://github.com/user-attachments/assets/90f355e2-d227-4d2a-a45e-bcfbb743d588)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Jedr Blaszyk <[email protected]>
(cherry picked from commit aec93bf)
@kibanamachine kibanamachine merged commit ba0730c into elastic:8.x Oct 29, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2312 2315 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +2.2KB

cc @JoseLuisGJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants