[Stateful sidenav] Update feedback urls #198143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
…date-feedback-urls
|
/ci |
sebelga
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
cc @sebelga |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
jloleysens
approved these changes
Oct 30, 2024
sphilipse
approved these changes
Oct 30, 2024
Dosant
approved these changes
Oct 30, 2024
TattdCodeMonkey
approved these changes
Oct 30, 2024
| @@ -195,7 +195,7 @@ export class NavigationPublicPlugin | |||
| } | |||
| } | |||
|
|
|||
| if (isProjectNav) { | |||
| if (isProjectNav && solutionView !== 'classic') { | |||
There was a problem hiding this comment.
is this to make typescript happy? isProjectNav will always be true when solutionView !== 'classic', i guess unless we introduce a different solutionView value in the future.
There was a problem hiding this comment.
Yep, just to make TS happy 😊
legrego
approved these changes
Oct 30, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 89fe548) # Conflicts: # x-pack/plugins/serverless_search/public/plugin.ts # x-pack/plugins/spaces/tsconfig.json
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 89fe548) # Conflicts: # x-pack/plugins/spaces/tsconfig.json
sebelga
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[Stateful sidenav] Update feedback urls (#198143)](#198143) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T08:55:49Z","message":"[Stateful sidenav] Update feedback urls (#198143)","sha":"89fe54815d9c25b860b34451f3045d43994ad42e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-major","Feature:Chrome"],"number":198143,"url":"https://github.com/elastic/kibana/pull/198143","mergeCommit":{"message":"[Stateful sidenav] Update feedback urls (#198143)","sha":"89fe54815d9c25b860b34451f3045d43994ad42e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198143","number":198143,"mergeCommit":{"message":"[Stateful sidenav] Update feedback urls (#198143)","sha":"89fe54815d9c25b860b34451f3045d43994ad42e"}}]}] BACKPORT-->
sebelga
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Update feedback urls (#198143)](#198143) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T08:55:49Z","message":"[Stateful sidenav] Update feedback urls (#198143)","sha":"89fe54815d9c25b860b34451f3045d43994ad42e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-major","Feature:Chrome"],"number":198143,"url":"https://github.com/elastic/kibana/pull/198143","mergeCommit":{"message":"[Stateful sidenav] Update feedback urls (#198143)","sha":"89fe54815d9c25b860b34451f3045d43994ad42e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198143","number":198143,"mergeCommit":{"message":"[Stateful sidenav] Update feedback urls (#198143)","sha":"89fe54815d9c25b860b34451f3045d43994ad42e"}},{"url":"https://github.com/elastic/kibana/pull/198479","number":198479,"branch":"8.16","state":"OPEN"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've updated the "Let us know" button URL to point to unique URLs based on the side nav solution.
New URLs
Note on implementation
I didn't want to introduce a new state on the ChromeService or create a dependency of the
spaceplugin on the SharedUX navigation package.I decided to change the
idtype of the navigation tree from astringto a strictSolutionIdtype.Most of the changes in this PR are to accommodate to this stricter requirements, with very little changes (and thus regression risks) to the implementation (those are mainly in packages/shared-ux/chrome/navigation/src/ui/navigation.tsx and packages/shared-ux/chrome/navigation/src/ui/components/feedback_btn.tsx).