[HTTP/OAS] Enable x-internal prop support in bundler's merge utility
#198104
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables support for
x-internalproperty in OpenAPI documents when merging them by OpenAPI Bundler's merge utility. It will help to prevent leaks of internal/WIP parts of OpenAPI bundles which weren't processed by the OpenAPI Bundler at the earlier stages.Details
@thomasneirynck brought up a Slack discussion (internal) regarding using of
x-internalproperty in OpenAPI documents for excluding parts of API endpoint definitions. OpenAPI bundler supports it and uses it for bundling Security Solution OpenAPI bundles. This PR enables this functionality for the merge utility used to merge OpenAPI bundles sourced from different parts of Kibana to produce a single Kibana bundle.