Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16] [ES|QL] detect the type of `COUNT(*)` (#197914) #198028

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[8.16] [ES|QL] detect the type of `COUNT(*)` (#197914) #198028

merged 1 commit into from
Oct 28, 2024
+53 −55

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

@drewdaemon
[ES|QL] detect the type of COUNT(*) (elastic#197914)
2869d72 
## Summary

We weren't properly detecting the type of the expression `COUNT(*)`. Now
we are!

Before:
<img width="950" alt="Screenshot 2024-10-25 at 4 38 08 PM"
src="https://github.com/user-attachments/assets/e9bd8d78-d0c8-4069-a818-5bf3486b925b">

After:
<img width="1093" alt="Screenshot 2024-10-25 at 4 35 44 PM"
src="https://github.com/user-attachments/assets/235c63dc-7d6c-49df-9adf-e225c4550a42">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Stratoula Kalafateli <[email protected]>
(cherry picked from commit a5f0c19)
@kibanamachine kibanamachine enabled auto-merge (squash) October 28, 2024 15:37
@kibanamachine kibanamachine mentioned this pull request Oct 28, 2024
Merged
1 task
@kibanamachine kibanamachine merged commit e060bee into elastic:8.16 Oct 28, 2024
26 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +81.0B

cc @drewdaemon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@drewdaemon drewdaemon

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @drewdaemon