[Cloud Security] Fix flaky metering tests #197950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
Summary
The error logs indicate that while we index N documents, the metering API intercepts only N-X documents. Previously, to address a similar issue, we switched to bulk indexing to ensure all test-related documents were indexed before tests began.
Although this adjustment resolved the problem in some flaky test runs, we still encountered intermittent failures in one of the hundreds runs.
Upon further investigation, I found that even with bulk indexing, there are rare cases where tests start before all relevant documents have finished indexing. I confirmed this by increasing the number of documents from 5 to 150, which made the error appear more consistently.
To address this, I updated the test logic to retry the expect assertion, reducing the likelihood of these occasional failures.