Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Add FTR API tests that validates creation of DOT indices #197899

Merged
merged 14 commits into from
Oct 31, 2024
Merged

[Security Solution][Endpoint] Add FTR API tests that validates creation of DOT indices #197899

merged 14 commits into from
Oct 31, 2024
+470 −49

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Oct 25, 2024 •
edited by kibanamachine
Loading

Summary

  • Adds new FTR API test suite for validating that DOT indices are created whenever a policy in fleet is created/updated
  • Renamed and moved DEFAULT_DIAGNOSTIC_INDEX const to security solution top-level common directory for better reuse
  • Moved utility function that builds an index name with the namespace included to top-level common directory for better reuse
  • Created some additional scripting methods in the Fleet services module for updating fleet policies

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 labels Oct 25, 2024
@paul-tavares paul-tavares self-assigned this Oct 25, 2024
@paul-tavares
Copy link
Contributor Author

/ci

@paul-tavares paul-tavares marked this pull request as ready for review October 28, 2024 13:48
@paul-tavares paul-tavares requested review from a team as code owners October 28, 2024 13:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

tomsonpl
tomsonpl approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@paul-tavares paul-tavares force-pushed the task/olm-10840-dot-prefix-indices-ftr-api-tests branch from 8b7641e to 9f243d2 Compare October 30, 2024 16:35
@paul-tavares paul-tavares enabled auto-merge (squash) October 30, 2024 16:35
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @paul-tavares

szaffarano
szaffarano approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@szaffarano szaffarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-tavares paul-tavares merged commit a5d571a into elastic:main Oct 31, 2024
43 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11614656214

@paul-tavares paul-tavares deleted the task/olm-10840-dot-prefix-indices-ftr-api-tests branch October 31, 2024 15:13
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 197899

Questions ?

Please refer to the Backport tool documentation

@paul-tavares paul-tavares mentioned this pull request Oct 31, 2024
Closed
@paul-tavares
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

paul-tavares added a commit to paul-tavares/kibana that referenced this pull request Oct 31, 2024
@paul-tavares
[Security Solution][Endpoint] Add FTR API tests that validates creati…
2458d8e 
…on of DOT indices (elastic#197899)

## Summary

- Adds new FTR API test suite for validating that DOT indices are
created whenever a policy in fleet is created/updated
- Renamed and moved `DEFAULT_DIAGNOSTIC_INDEX` `const` to security
solution top-level `common` directory for better reuse
- Moved utility function that builds an index name with the `namespace`
included to top-level `common` directory for better reuse
- Created some additional scripting methods in the Fleet services module
for updating fleet policies

(cherry picked from commit a5d571a)

# Conflicts:
#	x-pack/plugins/security_solution/server/fleet_integration/handlers/create_policy_datastreams.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

nreese pushed a commit to nreese/kibana that referenced this pull request Nov 1, 2024
@paul-tavares @nreese
[Security Solution][Endpoint] Add FTR API tests that validates creati…
1195611 
…on of DOT indices (elastic#197899)

## Summary

- Adds new FTR API test suite for validating that DOT indices are
created whenever a policy in fleet is created/updated
- Renamed and moved `DEFAULT_DIAGNOSTIC_INDEX` `const` to security
solution top-level `common` directory for better reuse
- Moved utility function that builds an index name with the `namespace`
included to top-level `common` directory for better reuse
- Created some additional scripting methods in the Fleet services module
for updating fleet policies
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@paul-tavares paul-tavares added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 4, 2024
@paul-tavares
Copy link
Contributor Author

Unable to backport

The backport can't be done because the associated change from Elasticsearch was not backported to 8.x.

@kibanamachine kibanamachine mentioned this pull request Dec 3, 2024
Merged
1 task
@kibanamachine kibanamachine mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@szaffarano szaffarano szaffarano approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino is a code owner automatically assigned from elastic/security-defend-workflows

Assignees

@paul-tavares paul-tavares

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paul-tavares @elasticmachine @kibanamachine @szaffarano @Ikuni17 @tomsonpl