Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [Kibana data view] Fix issue empty user-hash in data view request headers #197863

Merged
merged 16 commits into from
Oct 29, 2024
Merged

[8.15] [Kibana data view] Fix issue empty user-hash in data view request headers #197863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7fae4a3
Fix issue empty user-hash in data view request headers
muhamed-abdelgaber Oct 25, 2024
e554516
Merge branch 'main' into patch-1
muhamed-abdelgaber Oct 25, 2024
31d1aa2
Merge branch 'main' into patch-1
muhamed-abdelgaber Oct 25, 2024
beef5df
Merge branch 'main' into patch-1
muhamed-abdelgaber Oct 25, 2024
a1abe85
Merge branch 'main' into patch-1
muhamed-abdelgaber Oct 26, 2024
4976286
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Oct 28, 2024
c68b228
Merge branch 'main' into patch-1
elasticmachine Oct 28, 2024
65696c1
[8.15] [test] [data view] temp disable checking 'user-hash' header
muhamed-abdelgaber Oct 28, 2024
3ad7acd
Merge branch 'main' into patch-1
muhamed-abdelgaber Oct 28, 2024
623db27
Merge branch 'main' into patch-1
muhamed-abdelgaber Oct 28, 2024
ac05669
[8.15] [testing] [data view] disable checking 'user-hash' header
muhamed-abdelgaber Oct 28, 2024
1de89e3
[8.15] [dataview] replace empty header obj with undefined
Oct 28, 2024
26395fa
Merge branch 'main' into patch-1
muhamed-abdelgaber Oct 28, 2024
664f34a
Revert "[8.15] [dataview] replace empty header obj with undefined"
muhamed-abdelgaber Oct 28, 2024
85e8b52
[8.15] [dataview] replace empty header obj with undefined
muhamed-abdelgaber Oct 28, 2024
9a4b4fe
Merge branch 'main' into patch-1
muhamed-abdelgaber Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/plugins/data_views/public/data_views/data_views_api_client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ describe('IndexPatternsApiClient', () => {
expect(fetchSpy).toHaveBeenCalledWith(expectedPath, {
// not sure what asResponse is but the rest of the results are useful
asResponse: true,
headers: {
'user-hash': '',
},
query: {
allow_hidden: undefined,
allow_no_index: undefined,
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/data_views/public/data_views/data_views_api_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export class DataViewsApiClient implements IDataViewsApiClient {
const userId = await this.getCurrentUserId();

const userHash = userId ? await sha1(userId) : '';
const headers = userHash ? { 'user-hash': userHash } : undefined;

const request = body
? this.http.post<T>(url, { query, body, version, asResponse })
Expand All @@ -64,7 +65,7 @@ export class DataViewsApiClient implements IDataViewsApiClient {
version,
...cacheOptions,
asResponse,
headers: { 'user-hash': userHash },
headers,
});

return request.catch((resp) => {
Expand Down