Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ML] Update allocations tooltip to clarify that it's per node (#197099) #197846

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[8.x] [ML] Update allocations tooltip to clarify that it's per node (#197099) #197846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import type {
NodeDeploymentStatsResponse,
} from '../../../../common/types/trained_models';
import { useFieldFormatter } from '../../contexts/kibana/use_field_formatter';
import { useEnabledFeatures } from '../../contexts/ml';

interface AllocatedModelsProps {
models: NodeDeploymentStatsResponse['allocated_models'];
Expand All @@ -38,6 +39,7 @@ export const AllocatedModels: FC<AllocatedModelsProps> = ({
const dateFormatter = useFieldFormatter(FIELD_FORMAT_IDS.DATE);
const durationFormatter = useFieldFormatter(FIELD_FORMAT_IDS.DURATION);
const euiTheme = useEuiTheme();
const { showNodeInfo } = useEnabledFeatures();

const columns: Array<EuiBasicTableColumn<AllocatedModel>> = [
{
Expand Down Expand Up @@ -105,9 +107,20 @@ export const AllocatedModels: FC<AllocatedModelsProps> = ({
width: '8%',
name: (
<EuiToolTip
content={i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationTooltip', {
defaultMessage: 'number_of_allocations times threads_per_allocation',
})}
content={
showNodeInfo
? i18n.translate(
'xpack.ml.trainedModels.nodesList.modelsList.allocationTooltipNodes',
{
defaultMessage:
'Number of allocations per node multiplied by number of threads per allocation',
}
)
: i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationTooltip', {
defaultMessage:
'Number of allocations multiplied by number of threads per allocation',
})
}
>
<span>
{i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationHeader', {
Expand Down