Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [Synthetics] URL validation softens to allow vars usage !! (#197797) #197841

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

shahzad31
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…97797)

## Summary

URL validation softens to allow vars usage !!

For example

` should urls: "${url}" interpolate --params '{"url": "my-url"}'`

(cherry picked from commit 3b05b6a)

# Conflicts:
#	x-pack/plugins/observability_solution/synthetics/server/synthetics_service/project_monitor/normalizers/common_fields.ts
@shahzad31 shahzad31 enabled auto-merge (squash) October 25, 2024 14:48
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `docs-build` : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 28, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: a112e8b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197841-a112e8bb4b9f

Metrics [docs]

✅ unchanged

History

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 60d1b09 into elastic:8.15 Oct 28, 2024
25 checks passed
@shahzad31 shahzad31 deleted the backport/8.15/pr-197797 branch October 28, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants