Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16] [Synthetics] URL validation softens to allow vars usage !! (#197797) #197838

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[8.16] [Synthetics] URL validation softens to allow vars usage !! (#197797) #197838

merged 2 commits into from
Nov 5, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

@shahzad31
[Synthetics] URL validation softens to allow vars usage !! (elastic#1…
76857f1 
…97797)

## Summary

URL validation softens to allow vars usage !!

For example

` should urls: "${url}" interpolate --params '{"url": "my-url"}'`

(cherry picked from commit 3b05b6a)
@kibanamachine kibanamachine enabled auto-merge (squash) October 25, 2024 14:42
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Oct 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine mentioned this pull request Oct 25, 2024
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 5, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: d34e228
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197838-d34e228556ca

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @shahzad31

@kibanamachine kibanamachine merged commit fe73a24 into elastic:8.16 Nov 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@shahzad31 shahzad31

Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @shahzad31 @maryam-saeidi