Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discover async search relative timerange test #197740

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Fix discover async search relative timerange test #197740

merged 10 commits into from
Nov 5, 2024

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Oct 24, 2024 •
edited by kibanamachine
Loading

Summary

Resolves #195955.

@lukasolson lukasolson self-assigned this Oct 24, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7252

[❌] x-pack/test/search_sessions_integration/config.ts: 0/25 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7271

[✅] x-pack/test/search_sessions_integration/config.ts: 25/25 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7290

[❌] x-pack/test/search_sessions_integration/config.ts: 25/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7302

[❌] x-pack/test/search_sessions_integration/config.ts: 0/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7304

[❌] x-pack/test/search_sessions_integration/config.ts: 0/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7305

[✅] x-pack/test/search_sessions_integration/config.ts: 50/50 tests passed.

see run history

@lukasolson lukasolson marked this pull request as ready for review October 30, 2024 23:42
@lukasolson lukasolson requested review from a team as code owners October 30, 2024 23:42
@davismcphee davismcphee added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Nov 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 4, 2024
mbondyra
mbondyra approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner review 🆗

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @lukasolson

davismcphee
davismcphee approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukasolson lukasolson merged commit 4869b8f into elastic:main Nov 5, 2024
31 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11687992087

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 5, 2024
@lukasolson
Fix discover async search relative timerange test (elastic#197740)
380aa33 
## Summary

Resolves elastic#195955.

(cherry picked from commit 4869b8f)
@kibanamachine kibanamachine mentioned this pull request Nov 5, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 5, 2024
@kibanamachine @lukasolson
[8.x] Fix discover async search relative timerange test (#197740) (#1…
75613ac 
…99020)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix discover async search relative timerange test
(#197740)](#197740)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lukas
Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T16:03:49Z","message":"Fix
discover async search relative timerange test (#197740)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/195955.","sha":"4869b8f21c7bc2e0234bfddf7415646f72429c22","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"Fix
discover async search relative timerange
test","number":197740,"url":"https://github.com/elastic/kibana/pull/197740","mergeCommit":{"message":"Fix
discover async search relative timerange test (#197740)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/195955.","sha":"4869b8f21c7bc2e0234bfddf7415646f72429c22"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197740","number":197740,"mergeCommit":{"message":"Fix
discover async search relative timerange test (#197740)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/195955.","sha":"4869b8f21c7bc2e0234bfddf7415646f72429c22"}}]}]
BACKPORT-->

Co-authored-by: Lukas Olson <[email protected]>
mgadewoll pushed a commit to mgadewoll/kibana that referenced this pull request Nov 7, 2024
@lukasolson @mgadewoll
Fix discover async search relative timerange test (elastic#197740)
b8a6d22 
## Summary

Resolves elastic#195955.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees

@lukasolson lukasolson

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
5 participants
@lukasolson @kibanamachine @elasticmachine @mbondyra @davismcphee