[Search] refactor: unify license check utils #197675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced helpers for all the license checks and moved them to common utils so that they can be used outside of the licensing logic file. (we may even want to move these to a package in the future). Additionally I updated the logic to utilize the built-in License class utils instead of checking for specific license levels ourselves. This should improve the reliability in the case where we ever change license types etc.
TattdCodeMonkey
added
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 5a138e3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Search] refactor: unify license check utils (#197675)](#197675) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T12:19:23Z","message":"[Search] refactor: unify license check utils (#197675)","sha":"5a138e392ff794561dc9a18d9a631be181543dca","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.17.0"],"title":"[Search] refactor: unify license check utils","number":197675,"url":"https://github.com/elastic/kibana/pull/197675","mergeCommit":{"message":"[Search] refactor: unify license check utils (#197675)","sha":"5a138e392ff794561dc9a18d9a631be181543dca"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197675","number":197675,"mergeCommit":{"message":"[Search] refactor: unify license check utils (#197675)","sha":"5a138e392ff794561dc9a18d9a631be181543dca"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rodney Norris <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduced helpers for all the license checks and moved them to common utils so that they can be used outside of the licensing logic file. (we may even want to move these to a package in the future).
Additionally I updated the logic to utilize the built-in License class utils instead of checking for specific license levels ourselves. This should improve the reliability in the case where we ever change license types etc.
Checklist