Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Run type checking before tests #197539

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[ci] Run type checking before tests #197539

merged 2 commits into from
Oct 30, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 23, 2024

null

@jbudz
Copy link
Member Author

jbudz commented Oct 28, 2024

buildkite test this

@@ -136,11 +149,6 @@ steps:
provider: gcp
machineType: n2-standard-4
preemptible: true
depends_on:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be removed from on_merge.yml, they're blocked via the wait step above.

They're still needed on pull requests because the pipeline steps are dynamically added.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@jbudz jbudz marked this pull request as ready for review October 28, 2024 20:10
@jbudz jbudz requested a review from a team as a code owner October 28, 2024 20:10
@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Oct 28, 2024
@jbudz jbudz merged commit 9c90029 into elastic:main Oct 30, 2024
28 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11599153853

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts
8.16 Backport failed because of merge conflicts
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 197539

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants