Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Connectors] Allow to use POST method for get case information in case management webhook #197437

Merged
merged 14 commits into from
Nov 7, 2024
Merged

[ResponseOps][Connectors] Allow to use POST method for get case information in case management webhook #197437

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
283a8b8
initial commit
js-jankisalvi Oct 23, 2024
629a867
Fix tests
js-jankisalvi Oct 24, 2024
134675e
Merge branch 'main' into case-management-webhook-post-case-info
js-jankisalvi Oct 24, 2024
d9d7949
make system id optional in getIncidentUrl for POST
js-jankisalvi Oct 24, 2024
3e59d59
Merge branch 'case-management-webhook-post-case-info' of https://gith…
js-jankisalvi Oct 24, 2024
e0a8210
Merge branch 'main' into case-management-webhook-post-case-info
js-jankisalvi Oct 28, 2024
014790c
Merge branch 'main' into case-management-webhook-post-case-info
js-jankisalvi Oct 30, 2024
5eb6019
use only get and post
js-jankisalvi Nov 1, 2024
cb8554f
Merge branch 'main' into case-management-webhook-post-case-info
js-jankisalvi Nov 1, 2024
01b1307
Merge branch 'main' into case-management-webhook-post-case-info
js-jankisalvi Nov 4, 2024
ac83049
Merge branch 'main' into case-management-webhook-post-case-info
js-jankisalvi Nov 4, 2024
eb46790
feedback 2
js-jankisalvi Nov 6, 2024
5ab4836
removed externalId validation for json
js-jankisalvi Nov 7, 2024
e5d078d
Merge branch 'main' into case-management-webhook-post-case-info
js-jankisalvi Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions x-pack/plugins/actions/server/integration_tests/__snapshots__/connector_types.test.ts.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions x-pack/plugins/stack_connectors/common/auth/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ export enum WebhookMethods {
PATCH = 'patch',
POST = 'post',
PUT = 'put',
GET = 'get',
}
256 changes: 170 additions & 86 deletions x-pack/plugins/stack_connectors/public/connector_types/cases_webhook/steps/get.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,103 +6,187 @@
*/

import React, { FunctionComponent } from 'react';
import { css } from '@emotion/react';
import { EuiFlexGroup, EuiFlexItem, EuiText } from '@elastic/eui';
import { UseField } from '@kbn/es-ui-shared-plugin/static/forms/hook_form_lib';
import {
FIELD_TYPES,
UseField,
useFormData,
} from '@kbn/es-ui-shared-plugin/static/forms/hook_form_lib';
import { Field } from '@kbn/es-ui-shared-plugin/static/forms/components';
import { fieldValidators } from '@kbn/es-ui-shared-plugin/static/forms/helpers';
import { MustacheTextFieldWrapper } from '@kbn/triggers-actions-ui-plugin/public';
import { containsExternalId, containsExternalIdOrTitle } from '../validator';
import { JsonFieldWrapper, MustacheTextFieldWrapper } from '@kbn/triggers-actions-ui-plugin/public';
import { WebhookMethods } from '../../../../common/auth/constants';
import {
containsExternalIdForGet,
containsExternalIdForPost,
containsExternalIdOrTitle,
requiredJsonForPost,
} from '../validator';
import { urlVars, urlVarsExt } from '../action_variables';
import * as i18n from '../translations';
import { HTTP_VERBS } from '../webhook_connectors';
const { emptyField, urlField } = fieldValidators;

interface Props {
display: boolean;
readOnly: boolean;
}

export const GetStep: FunctionComponent<Props> = ({ display, readOnly }) => (
<span data-test-subj="getStep" style={{ display: display ? 'block' : 'none' }}>
<EuiText>
<h3>{i18n.STEP_3}</h3>
<small>
<p>{i18n.STEP_3_DESCRIPTION}</p>
</small>
</EuiText>
<EuiFlexGroup direction="column">
<EuiFlexItem>
<UseField
path="config.getIncidentUrl"
config={{
label: i18n.GET_INCIDENT_URL,
validations: [
{
validator: urlField(i18n.GET_INCIDENT_URL_REQUIRED),
},
{ validator: containsExternalId() },
],
helpText: i18n.GET_INCIDENT_URL_HELP,
}}
component={MustacheTextFieldWrapper}
componentProps={{
euiFieldProps: {
readOnly,
'data-test-subj': 'webhookGetUrlText',
messageVariables: urlVars,
paramsProperty: 'getIncidentUrl',
buttonTitle: i18n.ADD_CASES_VARIABLE,
showButtonTitle: true,
},
}}
/>
</EuiFlexItem>
<EuiFlexItem>
<UseField
path="config.getIncidentResponseExternalTitleKey"
config={{
label: i18n.GET_INCIDENT_TITLE_KEY,
validations: [
{
validator: emptyField(i18n.GET_RESPONSE_EXTERNAL_TITLE_KEY_REQUIRED),
export const GetStep: FunctionComponent<Props> = ({ display, readOnly }) => {
const [{ config }] = useFormData({
watch: ['config.getIncidentMethod'],
});
const { getIncidentMethod = WebhookMethods.GET } = config ?? {};

return (
<span data-test-subj="getStep" style={{ display: display ? 'block' : 'none' }}>
<EuiText>
<h3>{i18n.STEP_3}</h3>
<small>
<p>{i18n.STEP_3_DESCRIPTION}</p>
</small>
</EuiText>
<EuiFlexGroup direction="column">
<EuiFlexGroup justifyContent="spaceBetween">
<EuiFlexItem grow={false}>
<UseField
path="config.getIncidentMethod"
component={Field}
config={{
label: i18n.GET_INCIDENT_METHOD,
defaultValue: 'get',
js-jankisalvi marked this conversation as resolved.
Show resolved Hide resolved
type: FIELD_TYPES.SELECT,
validations: [
{
validator: emptyField(i18n.GET_METHOD_REQUIRED),
},
],
}}
css={css`
.euiFormRow__labelWrapper {
margin-bottom: 9px;
}
`}
componentProps={{
euiFieldProps: {
'data-test-subj': 'webhookGetIncidentMethodSelect',
options: HTTP_VERBS.map((verb) => ({
js-jankisalvi marked this conversation as resolved.
Show resolved Hide resolved
text: verb.toUpperCase(),
value: verb,
})),
readOnly,
},
}}
/>
</EuiFlexItem>
<EuiFlexItem>
<UseField
path="config.getIncidentUrl"
config={{
label: i18n.GET_INCIDENT_URL,
validations: [
{
validator: urlField(i18n.GET_INCIDENT_URL_REQUIRED),
},
{ validator: containsExternalIdForGet(getIncidentMethod) },
],
helpText: i18n.GET_INCIDENT_URL_HELP,
}}
component={MustacheTextFieldWrapper}
componentProps={{
euiFieldProps: {
readOnly,
'data-test-subj': 'webhookGetUrlText',
messageVariables: urlVars,
paramsProperty: 'getIncidentUrl',
buttonTitle: i18n.ADD_CASES_VARIABLE,
showButtonTitle: true,
},
}}
/>
</EuiFlexItem>
</EuiFlexGroup>
{getIncidentMethod === WebhookMethods.POST ? (
<EuiFlexItem>
<UseField
path="config.getIncidentJson"
config={{
helpText: i18n.GET_INCIDENT_JSON_HELP,
label: i18n.GET_INCIDENT_JSON,
validations: [
{
validator: requiredJsonForPost(getIncidentMethod),
},
{
validator: containsExternalIdForPost(getIncidentMethod),
js-jankisalvi marked this conversation as resolved.
Show resolved Hide resolved
},
],
}}
component={JsonFieldWrapper}
componentProps={{
euiCodeEditorProps: {
height: '200px',
isReadOnly: readOnly,
['aria-label']: i18n.CODE_EDITOR,
},
dataTestSubj: 'webhookGetIncidentJson',
messageVariables: urlVars,
paramsProperty: 'getIncidentJson',
buttonTitle: i18n.ADD_CASES_VARIABLE,
showButtonTitle: true,
}}
/>
</EuiFlexItem>
) : null}
<EuiFlexItem>
<UseField
path="config.getIncidentResponseExternalTitleKey"
config={{
label: i18n.GET_INCIDENT_TITLE_KEY,
validations: [
{
validator: emptyField(i18n.GET_RESPONSE_EXTERNAL_TITLE_KEY_REQUIRED),
},
],
helpText: i18n.GET_INCIDENT_TITLE_KEY_HELP,
}}
component={Field}
componentProps={{
euiFieldProps: {
readOnly,
'data-test-subj': 'getIncidentResponseExternalTitleKeyText',
},
],
helpText: i18n.GET_INCIDENT_TITLE_KEY_HELP,
}}
component={Field}
componentProps={{
euiFieldProps: {
readOnly,
'data-test-subj': 'getIncidentResponseExternalTitleKeyText',
},
}}
/>
</EuiFlexItem>
<EuiFlexItem>
<UseField
path="config.viewIncidentUrl"
config={{
label: i18n.EXTERNAL_INCIDENT_VIEW_URL,
validations: [
{
validator: urlField(i18n.GET_INCIDENT_VIEW_URL_REQUIRED),
}}
/>
</EuiFlexItem>
<EuiFlexItem>
<UseField
path="config.viewIncidentUrl"
config={{
label: i18n.EXTERNAL_INCIDENT_VIEW_URL,
validations: [
{
validator: urlField(i18n.GET_INCIDENT_VIEW_URL_REQUIRED),
},
{ validator: containsExternalIdOrTitle() },
],
helpText: i18n.EXTERNAL_INCIDENT_VIEW_URL_HELP,
}}
component={MustacheTextFieldWrapper}
componentProps={{
euiFieldProps: {
readOnly,
'data-test-subj': 'viewIncidentUrlText',
messageVariables: urlVarsExt,
paramsProperty: 'viewIncidentUrl',
buttonTitle: i18n.ADD_CASES_VARIABLE,
showButtonTitle: true,
},
{ validator: containsExternalIdOrTitle() },
],
helpText: i18n.EXTERNAL_INCIDENT_VIEW_URL_HELP,
}}
component={MustacheTextFieldWrapper}
componentProps={{
euiFieldProps: {
readOnly,
'data-test-subj': 'viewIncidentUrlText',
messageVariables: urlVarsExt,
paramsProperty: 'viewIncidentUrl',
buttonTitle: i18n.ADD_CASES_VARIABLE,
showButtonTitle: true,
},
}}
/>
</EuiFlexItem>
</EuiFlexGroup>
</span>
);
}}
/>
</EuiFlexItem>
</EuiFlexGroup>
</span>
);
};
Loading