Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ingest pipeline mgmt] sort list of ip location databases for consistent output #197361

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 23, 2024

Summary

Sort ip location database list for api output. Consistent results are testable results.

Closes: #196765

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7212

[❌] x-pack/test/api_integration/apis/management/config.ts: 0/1 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7225

[❌] x-pack/test/api_integration/apis/management/config.ts: 0/1 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7233

[✅] x-pack/test/api_integration/apis/management/config.ts: 25/25 tests passed.

see run history

@mattkime mattkime self-assigned this Oct 23, 2024
@mattkime mattkime changed the title sort results, otherwise they're semi-random [ingest pipeline mgmt] sort list of ip location databases for consistent output Oct 23, 2024
@mattkime mattkime added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 23, 2024
@elastic elastic deleted a comment from kibanamachine Oct 23, 2024
@elastic elastic deleted a comment from kibanamachine Oct 23, 2024
@mattkime
Copy link
Contributor Author

/ci

@mattkime mattkime requested a review from ElenaStoeva October 23, 2024 19:27
@mattkime mattkime force-pushed the ingest_pipeline_api_flaky_test_fix branch from d6d512d to 0dc493b Compare October 23, 2024 19:47
@mattkime
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7235

[✅] x-pack/test/api_integration/apis/content_management/config.ts: 200/200 tests passed.

see run history

@mattkime
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @mattkime

@mattkime mattkime marked this pull request as ready for review October 23, 2024 23:40
@mattkime mattkime requested a review from a team as a code owner October 23, 2024 23:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests! Changes lgtm.

@mattkime mattkime merged commit fb2452e into elastic:main Oct 24, 2024
25 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11497110971

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 197361

Questions ?

Please refer to the Backport tool documentation

@mattkime
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mattkime added a commit to mattkime/kibana that referenced this pull request Oct 24, 2024
…ent output (elastic#197361)

## Summary

Sort ip location database list for api output. Consistent results are
testable results.

Closes: elastic#196765
(cherry picked from commit fb2452e)

# Conflicts:
#	x-pack/test/api_integration/apis/management/ingest_pipelines/databases.ts
mattkime added a commit that referenced this pull request Oct 25, 2024
…onsistent output (#197361) (#197672)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ingest pipeline mgmt] sort list of ip location databases for
consistent output
(#197361)](#197361)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T10:06:06Z","message":"[ingest
pipeline mgmt] sort list of ip location databases for consistent output
(#197361)\n\n## Summary\r\n\r\nSort ip location database list for api
output. Consistent results are\r\ntestable results.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/196765","sha":"fb2452e1a129fbefe0866b734ae4111e63222cad","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","Feature:Ingest Node
Pipelines","backport:prev-minor"],"number":197361,"url":"https://github.com/elastic/kibana/pull/197361","mergeCommit":{"message":"[ingest
pipeline mgmt] sort list of ip location databases for consistent output
(#197361)\n\n## Summary\r\n\r\nSort ip location database list for api
output. Consistent results are\r\ntestable results.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/196765","sha":"fb2452e1a129fbefe0866b734ae4111e63222cad"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197361","number":197361,"mergeCommit":{"message":"[ingest
pipeline mgmt] sort list of ip location databases for consistent output
(#197361)\n\n## Summary\r\n\r\nSort ip location database list for api
output. Consistent results are\r\ntestable results.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/196765","sha":"fb2452e1a129fbefe0866b734ae4111e63222cad"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.17.0 v9.0.0
Projects
None yet
4 participants