[8.x] [Lens] dont use legacy metric in the suggestions (#197101) #197337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fixes elastic#197078 (cherry picked from commit 6f44bf5)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mbondyra
approved these changes
Oct 25, 2024
jughosta
approved these changes
Oct 25, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @mbondyra |
mbondyra
added a commit
that referenced
this pull request
Oct 25, 2024
Fixes #197342 In this PR (#197101) I removed the legacy metric from being suggested in the suggestion panel, and replaced it with the new metric visualization. To maintain the previous behavior in Lens (suggesting a new metric in the same place as legacy metric), we made the score higher for the new metric. This positioned it higher also in the Discover ESQL suggestions. This led to an issue where one expected suggestion didn’t appear because we only display the top 6 suggestions by score and it got pushed out by metric. Additionally, I made a change here to only display the metric without bucketed columns in the suggestion panel. I don't see there's a lot of value in suggesting bucketed metric unless it's something user chooses intentionally. Should be merged to 8.x after this: #197337
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
Fixes elastic#197342 In this PR (elastic#197101) I removed the legacy metric from being suggested in the suggestion panel, and replaced it with the new metric visualization. To maintain the previous behavior in Lens (suggesting a new metric in the same place as legacy metric), we made the score higher for the new metric. This positioned it higher also in the Discover ESQL suggestions. This led to an issue where one expected suggestion didn’t appear because we only display the top 6 suggestions by score and it got pushed out by metric. Additionally, I made a change here to only display the metric without bucketed columns in the suggestion panel. I don't see there's a lot of value in suggesting bucketed metric unless it's something user chooses intentionally. Should be merged to 8.x after this: elastic#197337 (cherry picked from commit b3b85da)
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Fix suggestions for ES|QL charts (#197583)](#197583) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T15:17:02Z","message":"[Discover] Fix suggestions for ES|QL charts (#197583)\n\nFixes https://github.com/elastic/kibana/issues/197342\r\n\r\nIn this PR (#197101) I removed the\r\nlegacy metric from being suggested in the suggestion panel, and replaced\r\nit with the new metric visualization. To maintain the previous behavior\r\nin Lens (suggesting a new metric in the same place as legacy metric), we\r\nmade the score higher for the new metric. This positioned it higher also\r\nin the Discover ESQL suggestions. This led to an issue where one\r\nexpected suggestion didn’t appear because we only display the top 6\r\nsuggestions by score and it got pushed out by metric.\r\n\r\nAdditionally, I made a change here to only display the metric without\r\nbucketed columns in the suggestion panel. I don't see there's a lot of\r\nvalue in suggesting bucketed metric unless it's something user chooses\r\nintentionally.\r\n\r\nShould be merged to 8.x after this:\r\nhttps://github.com//pull/197337","sha":"b3b85da80d0c9a8431f6a2f2e3c1bdf1448eb1a6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","Team:Visualizations","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Discover] Fix suggestions for ES|QL charts","number":197583,"url":"https://github.com/elastic/kibana/pull/197583","mergeCommit":{"message":"[Discover] Fix suggestions for ES|QL charts (#197583)\n\nFixes https://github.com/elastic/kibana/issues/197342\r\n\r\nIn this PR (#197101) I removed the\r\nlegacy metric from being suggested in the suggestion panel, and replaced\r\nit with the new metric visualization. To maintain the previous behavior\r\nin Lens (suggesting a new metric in the same place as legacy metric), we\r\nmade the score higher for the new metric. This positioned it higher also\r\nin the Discover ESQL suggestions. This led to an issue where one\r\nexpected suggestion didn’t appear because we only display the top 6\r\nsuggestions by score and it got pushed out by metric.\r\n\r\nAdditionally, I made a change here to only display the metric without\r\nbucketed columns in the suggestion panel. I don't see there's a lot of\r\nvalue in suggesting bucketed metric unless it's something user chooses\r\nintentionally.\r\n\r\nShould be merged to 8.x after this:\r\nhttps://github.com//pull/197337","sha":"b3b85da80d0c9a8431f6a2f2e3c1bdf1448eb1a6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197583","number":197583,"mergeCommit":{"message":"[Discover] Fix suggestions for ES|QL charts (#197583)\n\nFixes https://github.com/elastic/kibana/issues/197342\r\n\r\nIn this PR (#197101) I removed the\r\nlegacy metric from being suggested in the suggestion panel, and replaced\r\nit with the new metric visualization. To maintain the previous behavior\r\nin Lens (suggesting a new metric in the same place as legacy metric), we\r\nmade the score higher for the new metric. This positioned it higher also\r\nin the Discover ESQL suggestions. This led to an issue where one\r\nexpected suggestion didn’t appear because we only display the top 6\r\nsuggestions by score and it got pushed out by metric.\r\n\r\nAdditionally, I made a change here to only display the metric without\r\nbucketed columns in the suggestion panel. I don't see there's a lot of\r\nvalue in suggesting bucketed metric unless it's something user chooses\r\nintentionally.\r\n\r\nShould be merged to 8.x after this:\r\nhttps://github.com//pull/197337","sha":"b3b85da80d0c9a8431f6a2f2e3c1bdf1448eb1a6"}}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation