[ES|QL] Create validation errors for unknown parameters #197334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
added
v9.0.0
v8.16.0
v8.17.0
Team:ESQL
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
|
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Oct 23, 2024
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2024
## Summary Follow-up from elastic#195989. We discussed as a team and decided to show validation errors when an unknown variable is used as an argument to subsequent functions. **Before** <img width="589" alt="Screenshot 2024-10-22 at 1 41 08 PM" src="https://github.com/user-attachments/assets/872d3302-ddfe-415f-9c98-e2c682344189"> **After** <img width="570" alt="Screenshot 2024-10-22 at 1 41 29 PM" src="https://github.com/user-attachments/assets/b7e29c2d-ee40-4730-b1ab-43d95dfd264c"> (cherry picked from commit e1c0cef)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2024
## Summary Follow-up from elastic#195989. We discussed as a team and decided to show validation errors when an unknown variable is used as an argument to subsequent functions. **Before** <img width="589" alt="Screenshot 2024-10-22 at 1 41 08 PM" src="https://github.com/user-attachments/assets/872d3302-ddfe-415f-9c98-e2c682344189"> **After** <img width="570" alt="Screenshot 2024-10-22 at 1 41 29 PM" src="https://github.com/user-attachments/assets/b7e29c2d-ee40-4730-b1ab-43d95dfd264c"> (cherry picked from commit e1c0cef)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
…) (#197451) # Backport This will backport the following commits from `main` to `8.16`: - [[ES|QL] Create validation errors for unknown parameters (#197334)](#197334) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T13:49:38Z","message":"[ES|QL] Create validation errors for unknown parameters (#197334)\n\n## Summary\r\n\r\nFollow-up from https://github.com/elastic/kibana/pull/195989.\r\n\r\nWe discussed as a team and decided to show validation errors when an\r\nunknown variable is used as an argument to subsequent functions.\r\n\r\n**Before**\r\n<img width=\"589\" alt=\"Screenshot 2024-10-22 at 1 41 08 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/872d3302-ddfe-415f-9c98-e2c682344189\">\r\n\r\n\r\n**After**\r\n<img width=\"570\" alt=\"Screenshot 2024-10-22 at 1 41 29 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/b7e29c2d-ee40-4730-b1ab-43d95dfd264c\">","sha":"e1c0cef15dd7f771a621db0230bf4cddcf10815b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","v8.16.0","backport:version","v8.17.0"],"title":"[ES|QL] Create validation errors for unknown parameters","number":197334,"url":"https://github.com/elastic/kibana/pull/197334","mergeCommit":{"message":"[ES|QL] Create validation errors for unknown parameters (#197334)\n\n## Summary\r\n\r\nFollow-up from https://github.com/elastic/kibana/pull/195989.\r\n\r\nWe discussed as a team and decided to show validation errors when an\r\nunknown variable is used as an argument to subsequent functions.\r\n\r\n**Before**\r\n<img width=\"589\" alt=\"Screenshot 2024-10-22 at 1 41 08 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/872d3302-ddfe-415f-9c98-e2c682344189\">\r\n\r\n\r\n**After**\r\n<img width=\"570\" alt=\"Screenshot 2024-10-22 at 1 41 29 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/b7e29c2d-ee40-4730-b1ab-43d95dfd264c\">","sha":"e1c0cef15dd7f771a621db0230bf4cddcf10815b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197334","number":197334,"mergeCommit":{"message":"[ES|QL] Create validation errors for unknown parameters (#197334)\n\n## Summary\r\n\r\nFollow-up from https://github.com/elastic/kibana/pull/195989.\r\n\r\nWe discussed as a team and decided to show validation errors when an\r\nunknown variable is used as an argument to subsequent functions.\r\n\r\n**Before**\r\n<img width=\"589\" alt=\"Screenshot 2024-10-22 at 1 41 08 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/872d3302-ddfe-415f-9c98-e2c682344189\">\r\n\r\n\r\n**After**\r\n<img width=\"570\" alt=\"Screenshot 2024-10-22 at 1 41 29 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/b7e29c2d-ee40-4730-b1ab-43d95dfd264c\">","sha":"e1c0cef15dd7f771a621db0230bf4cddcf10815b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
… (#197452) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Create validation errors for unknown parameters (#197334)](#197334) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T13:49:38Z","message":"[ES|QL] Create validation errors for unknown parameters (#197334)\n\n## Summary\r\n\r\nFollow-up from https://github.com/elastic/kibana/pull/195989.\r\n\r\nWe discussed as a team and decided to show validation errors when an\r\nunknown variable is used as an argument to subsequent functions.\r\n\r\n**Before**\r\n<img width=\"589\" alt=\"Screenshot 2024-10-22 at 1 41 08 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/872d3302-ddfe-415f-9c98-e2c682344189\">\r\n\r\n\r\n**After**\r\n<img width=\"570\" alt=\"Screenshot 2024-10-22 at 1 41 29 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/b7e29c2d-ee40-4730-b1ab-43d95dfd264c\">","sha":"e1c0cef15dd7f771a621db0230bf4cddcf10815b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","v8.16.0","backport:version","v8.17.0"],"title":"[ES|QL] Create validation errors for unknown parameters","number":197334,"url":"https://github.com/elastic/kibana/pull/197334","mergeCommit":{"message":"[ES|QL] Create validation errors for unknown parameters (#197334)\n\n## Summary\r\n\r\nFollow-up from https://github.com/elastic/kibana/pull/195989.\r\n\r\nWe discussed as a team and decided to show validation errors when an\r\nunknown variable is used as an argument to subsequent functions.\r\n\r\n**Before**\r\n<img width=\"589\" alt=\"Screenshot 2024-10-22 at 1 41 08 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/872d3302-ddfe-415f-9c98-e2c682344189\">\r\n\r\n\r\n**After**\r\n<img width=\"570\" alt=\"Screenshot 2024-10-22 at 1 41 29 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/b7e29c2d-ee40-4730-b1ab-43d95dfd264c\">","sha":"e1c0cef15dd7f771a621db0230bf4cddcf10815b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197334","number":197334,"mergeCommit":{"message":"[ES|QL] Create validation errors for unknown parameters (#197334)\n\n## Summary\r\n\r\nFollow-up from https://github.com/elastic/kibana/pull/195989.\r\n\r\nWe discussed as a team and decided to show validation errors when an\r\nunknown variable is used as an argument to subsequent functions.\r\n\r\n**Before**\r\n<img width=\"589\" alt=\"Screenshot 2024-10-22 at 1 41 08 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/872d3302-ddfe-415f-9c98-e2c682344189\">\r\n\r\n\r\n**After**\r\n<img width=\"570\" alt=\"Screenshot 2024-10-22 at 1 41 29 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/b7e29c2d-ee40-4730-b1ab-43d95dfd264c\">","sha":"e1c0cef15dd7f771a621db0230bf4cddcf10815b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from #195989.
We discussed as a team and decided to show validation errors when an unknown variable is used as an argument to subsequent functions.
Before
After
