New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Removing cypress folder #197273

Merged

MadameSheema merged 9 commits into elastic:main from MadameSheema:deleting-folder

Oct 24, 2024

+61 −737

Member

MadameSheema commented Oct 22, 2024 •

edited by kibanamachine

Loading

Summary

Deleting the Cypress folder that was added in test_serverless as a POC.

Currently is not used and this can create misunderstandings regarding ownership of it.


          removing cypress folder

13f7555

MadameSheema added release_note:skip Team: SecuritySolution backport:prev-major v8.16.0 v8.17.0 labels

MadameSheema self-assigned this

MadameSheema requested review from a team as code owners

October 22, 2024 15:10

Contributor

elasticmachine commented Oct 22, 2024

Pinging @elastic/security-solution (Team: SecuritySolution)


          Merge branch 'main' into deleting-folder

35d00ab

MadameSheema requested a review from szwarckonrad

October 22, 2024 15:18


          [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

b893378

…fix'

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner

October 22, 2024 15:25

wayneseymour approved these changes

View reviewed changes

Member

wayneseymour left a comment

x-pack/test_serverless/tsconfig.json removal lgtm!

charlie-pichette approved these changes

View reviewed changes

Contributor

charlie-pichette left a comment

Thanks for doing this @MadameSheema!

Ikuni17 approved these changes

View reviewed changes


          fixes

d70f4a9

MadameSheema requested a review from a team as a code owner

October 23, 2024 10:59

MadameSheema requested a review from tomsonpl

October 23, 2024 10:59

MadameSheema added 4 commits

October 23, 2024 14:12


          updates path

1a32d01


          fixes

9a2b838


          fixing quick checks issue

7ed3215


          Merge branch 'main' into deleting-folder

5cb586d

Contributor

tomsonpl commented Oct 24, 2024

@paul-tavares could you please take a look at this? It seems like you were the one who originally introduced these functionalities. From my perspective, it looks safe to remove, but I wanted to get your opinion before proceeding. Thanks!

tomsonpl requested review from paul-tavares and removed request for tomsonpl

October 24, 2024 08:45

szwarckonrad approved these changes

View reviewed changes

Contributor

szwarckonrad left a comment

LGTM, thanks for addressing this!

.buildkite/ftr_security_serverless_configs.yml Outdated

Comment on lines 11 to 12

		- x-pack/test/defend_workflows_cypress/serverless_config.base.ts
		- x-pack/test/osquery_cypress/serverless_config.base.ts

Contributor

szwarckonrad Oct 24, 2024

Shouldn't base configs be placed in the section above?

Member Author

MadameSheema Oct 24, 2024

Looks like! Thanks for noticing :)


          refactor

cd055d3

Contributor

elasticmachine commented Oct 24, 2024

💚 Build Succeeded

Buildkite Build
Commit: cd055d3

Metrics [docs]

✅ unchanged

History

💚 Build #245429 succeeded 5cb586d
💔 Build #245216 failed 7ed3215
💔 Build #245065 failed 9a2b838
💔 Build #245033 failed 1a32d01
💔 Build #244991 failed d70f4a9
💔 Build #244736 failed b893378

cc @MadameSheema

paul-tavares approved these changes

View reviewed changes

MadameSheema merged commit 86e6c74 into elastic:main

27 checks passed

MadameSheema deleted the deleting-folder branch

October 24, 2024 15:26

kibanamachine added the v9.0.0 label

Contributor

kibanamachine commented Oct 24, 2024

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11502485366

kibanamachine added the backport missing label

Contributor

kibanamachine commented Oct 25, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

1 similar comment

Contributor

kibanamachine commented Oct 28, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

kibanamachine mentioned this pull request

[ci] Run linting before tests #197310

Merged

Contributor

kibanamachine commented Oct 29, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

4 similar comments

Contributor

kibanamachine commented Oct 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

Contributor

kibanamachine commented Oct 31, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

Contributor

kibanamachine commented Nov 1, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

Contributor

kibanamachine commented Nov 4, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

This was referenced Nov 4, 2024

[ci] Run checks before tests #198452

Merged

[ci] Remove local SSDs #198618

Merged

Contributor

kibanamachine commented Nov 5, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

1 similar comment

Contributor

kibanamachine commented Nov 6, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

ashokaditya added backport:version and removed backport:prev-major labels

Contributor

kibanamachine commented Nov 7, 2024

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11718794852

Contributor

kibanamachine commented Nov 7, 2024

💔 All backports failed

Status	Branch	Result
❌	8.16	Backport failed because of merge conflicts
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 197273

Questions ?

Please refer to the Backport tool documentation

This was referenced Nov 7, 2024

[8.x] [Security Solution] Removing cypress folder (#197273) #199260

Merged

[8.16] [Security Solution] Removing cypress folder (#197273) #199261

Merged

Member

ashokaditya commented Nov 7, 2024

💚 All backports created successfully

Status	Branch	Result
✅	8.x
✅	8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ashokaditya pushed a commit to ashokaditya/kibana that referenced this pull request


          [Security Solution] Removing cypress folder (elastic#197273)

1043deb

## Summary

Deleting the Cypress folder that was added in `test_serverless` as a
POC.

Currently is not used and this can create misunderstandings regarding
ownership of it.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 86e6c74)

# Conflicts:
#	.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
#	.github/CODEOWNERS

ashokaditya pushed a commit to ashokaditya/kibana that referenced this pull request


          [Security Solution] Removing cypress folder (elastic#197273)

3a1615e

## Summary

Deleting the Cypress folder that was added in `test_serverless` as a
POC.

Currently is not used and this can create misunderstandings regarding
ownership of it.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 86e6c74)

# Conflicts:
#	.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
#	.github/CODEOWNERS

ashokaditya added a commit that referenced this pull request


          [8.16] [Security Solution] Removing cypress folder (#197273) (#199261)

5d1e095

> [!Warning]
> `.github/CODEOWNERS` and
`.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml`
were updated as part of merge conflicts so would need a thorough review.

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution] Removing cypress folder
(#197273)](#197273)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T15:26:33Z","message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","Team:
SecuritySolution","v8.16.0","backport:version","v8.17.0"],"number":197273,"url":"https://github.com/elastic/kibana/pull/197273","mergeCommit":{"message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197273","number":197273,"mergeCommit":{"message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Gloria Hornero <[email protected]>
Co-authored-by: kibanamachine <[email protected]>

ashokaditya added a commit that referenced this pull request


          [8.x] [Security Solution] Removing cypress folder (#197273) (#199260)

feab4ef

> [!Warning]
> `.github/CODEOWNERS` and
`.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml`
were updated as part of merge conflicts so would need a thorough review.

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Removing cypress folder
(#197273)](#197273)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T15:26:33Z","message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","Team:
SecuritySolution","v8.16.0","backport:version","v8.17.0"],"number":197273,"url":"https://github.com/elastic/kibana/pull/197273","mergeCommit":{"message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197273","number":197273,"mergeCommit":{"message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Gloria Hornero <[email protected]>
Co-authored-by: kibanamachine <[email protected]>

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

paul-tavares paul-tavares approved these changes

charlie-pichette charlie-pichette approved these changes

szwarckonrad szwarckonrad approved these changes

Ikuni17 Ikuni17 approved these changes

wayneseymour wayneseymour approved these changes

Labels

backport:version release_note:skip Team: SecuritySolution v8.16.0 v8.17.0 v9.0.0