Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search][FTR] Fix / Improve tests #197264

Merged
merged 4 commits into from
Oct 22, 2024
Merged

[Search][FTR] Fix / Improve tests #197264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d1fda2
test(search index details): check for documents first
TattdCodeMonkey Oct 22, 2024
03c3f62
test: use regex for url checks
TattdCodeMonkey Oct 22, 2024
39f4a63
test(es3): navigateion - remove maps check
TattdCodeMonkey Oct 22, 2024
25616df
test(es3): update getting started to use dev role instead of admin
TattdCodeMonkey Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/test_serverless/functional/page_objects/svl_search_elasticsearch_start_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ export function SvlSearchElasticsearchStartPageProvider({ getService }: FtrProvi
},
async expectO11yTrialLink() {
await testSubjects.existOrFail('startO11yTrialBtn');
expect(await testSubjects.getAttribute('startO11yTrialBtn', 'href')).equal(
'https://fake-cloud.elastic.co/projects/create/observability/start'
expect(await testSubjects.getAttribute('startO11yTrialBtn', 'href')).match(
/^https?\:\/\/.*\/projects\/create\/observability\/start/
);
expect(await testSubjects.getAttribute('startO11yTrialBtn', 'target')).equal('_blank');
},
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test_serverless/functional/page_objects/svl_search_index_detail_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ export function SvlSearchIndexDetailPageProvider({ getService }: FtrProviderCont
},
async expectConnectionDetails() {
await testSubjects.existOrFail('connectionDetailsEndpoint', { timeout: 2000 });
expect(await (await testSubjects.find('connectionDetailsEndpoint')).getVisibleText()).to.be(
'https://fakeprojectid.es.fake-domain.cld.elstc.co:443'
expect(await (await testSubjects.find('connectionDetailsEndpoint')).getVisibleText()).match(
/^https?\:\/\/.*(\:\d+)?/
);
},
async expectQuickStats() {
Expand Down
3 changes: 0 additions & 3 deletions x-pack/test_serverless/functional/test_suites/search/elasticsearch_start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
};

describe('Elasticsearch Start [Onboarding Empty State]', function () {
// fails on MKI, see https://github.com/elastic/kibana/issues/196981
this.tags(['failsOnMKI']);

describe('developer', function () {
before(async () => {
await pageObjects.svlCommonPage.loginWithRole('developer');
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test_serverless/functional/test_suites/search/getting_started.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {

describe('getting started', function () {
before(async () => {
await pageObjects.svlCommonPage.loginAsAdmin();
await pageObjects.svlCommonPage.loginWithRole('developer');
});

it('has serverless side nav', async () => {
Expand Down
15 changes: 0 additions & 15 deletions x-pack/test_serverless/functional/test_suites/search/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,21 +130,6 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({
deepLinkId: 'dashboards',
});
// check Other tools
// > Maps
await solutionNavigation.sidenav.clickLink({
deepLinkId: 'maps',
});
await solutionNavigation.sidenav.expectLinkActive({
deepLinkId: 'maps',
});
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({ text: 'Other tools' });
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({
text: 'Maps',
});
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({
deepLinkId: 'maps',
});

// check Getting Started
await solutionNavigation.sidenav.clickLink({
Expand Down
9 changes: 3 additions & 6 deletions x-pack/test_serverless/functional/test_suites/search/search_index_detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const indexName = 'test-my-index';

describe('Search index detail page', function () {
// fails on MKI, see https://github.com/elastic/kibana/issues/196981
this.tags(['failsOnMKI']);

before(async () => {
await pageObjects.svlCommonPage.loginWithRole('developer');
await pageObjects.svlApiKeys.deleteAPIKeys();
Expand Down Expand Up @@ -120,16 +117,16 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
await svlSearchNavigation.navigateToIndexDetailPage(indexName);
});
it('should have index documents', async () => {
await pageObjects.svlSearchIndexDetailPage.expectHasIndexDocuments();
});
it('menu action item should be replaced with playground', async () => {
await pageObjects.svlSearchIndexDetailPage.expectActionItemReplacedWhenHasDocs();
});
it('should have link to API reference doc link in options menu', async () => {
await pageObjects.svlSearchIndexDetailPage.clickMoreOptionsActionsButton();
await pageObjects.svlSearchIndexDetailPage.expectAPIReferenceDocLinkExistsInMoreOptions();
});
it('should have index documents', async () => {
await pageObjects.svlSearchIndexDetailPage.expectHasIndexDocuments();
});
it('should have one document in quick stats', async () => {
await pageObjects.svlSearchIndexDetailPage.expectQuickStatsToHaveDocumentCount(1);
});
Expand Down