Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Fix AggConfig backslash escaping (#193932) #197251

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Oct 22, 2024

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

## Summary

Fixes `AggConfig` handling to properly escape backslash as well as the
single quote it already escapes.

(I believe this has been around ever since
elastic#2486.)

(cherry picked from commit 9916dd0)
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 454.7KB 454.8KB +28.0B

History

@lukasolson lukasolson merged commit 00b6b9d into elastic:7.17 Oct 22, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants