[Observability Onboarding] Fix small UI issues #197234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
mykolaharmash
added
release_note:skip
mykolaharmash
force-pushed
the
design-fixes
branch
2 times, most recently
from
f7a951c to
2c7e1ee
Compare
|
@akhileshpok @gbamparop Just to make sure, did we agree with @mlunadia to remove the link to the feedback form? |
|
@mykolaharmash I guess we still need to remove the "Was this helpful or were there..." text? 
|
|
@flash1293, @gbamparop - No, I completely forgot to validate this with @mlunadia. Due to the time constraints, would it be possible to include the 'Give feedback' button next to the user sentiment options (Note - we should not remove user sentiment collection)? 
Fyi - I have just noticed that the EDOT Collector based onboarding flow for Hosts also just has the 'Give feedback' button at the bottom, without user sentiment collection. If possible, we should make the UX consistent for all EDOT Collector based onboarding workflows. Apologies for the confusion! |
Yes, I think that we should remove this text. |
|
On stateful with the new nav enabled, the "Give Feedback" button at the top of the page is not part of the top nav: 
This is serverless: 
|
oh, true, not sure how I missed it 🙈 |
Right, but those are two different buttons. On serverless it has a global feedback button always in the top bar and we hide our button completely to not have two of them. In the new nav, it's our button but as far as I know we cannot place it in the top bar, only in the action bar bellow it. |
Got it, let's leave that one in for now. With "Was this helpful or were there..." removed I think we are good - checked with @mlunadia offline and we are good with removing the old otel "Give Feedback" button from the flow |
got it, thank you for clarifying! |
mykolaharmash
force-pushed
the
design-fixes
branch
from
f820032 to
0611294
Compare
mykolaharmash
force-pushed
the
design-fixes
branch
from
632f95c to
6e3dcc2
Compare
⏳ Build in-progress
History
|
|
Starting backport for target branches: 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
Closes elastic/observability-dev#4015 🔒 * Makes the footer's top boarder to span across the full page width * Removes the empty header action menu on the main onboarding screen when using the new solution sidenav * Replaces "Give feedback" button on the EDOT collector flow with the feedback buttons used in other flows Other things mentioned in [the issue](elastic/observability-dev#4015) have been resolved already by previous changes.  To enable the new solution navigation locally: 1. Add these to `kibana.dev.yml` ``` xpack.spaces.allowSolutionVisibility: true xpack.spaces.experimental.forceSolutionVisibility: true ``` 2. Run Kibana and navigate to Spaces Management 3. Set "Observability" view for the space you're using locally (most likely "Default") (cherry picked from commit 1821093)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
Closes elastic/observability-dev#4015 🔒 * Makes the footer's top boarder to span across the full page width * Removes the empty header action menu on the main onboarding screen when using the new solution sidenav * Replaces "Give feedback" button on the EDOT collector flow with the feedback buttons used in other flows Other things mentioned in [the issue](elastic/observability-dev#4015) have been resolved already by previous changes.  To enable the new solution navigation locally: 1. Add these to `kibana.dev.yml` ``` xpack.spaces.allowSolutionVisibility: true xpack.spaces.experimental.forceSolutionVisibility: true ``` 2. Run Kibana and navigate to Spaces Management 3. Set "Observability" view for the space you're using locally (most likely "Default") (cherry picked from commit 1821093)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
) # Backport This will backport the following commits from `main` to `8.16`: - [[Observability Onboarding] Fix small UI issues (#197234)](#197234) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T16:29:52Z","message":"[Observability Onboarding] Fix small UI issues (#197234)\n\nCloses elastic/observability-dev#4015 🔒\r\n\r\n* Makes the footer's top boarder to span across the full page width\r\n* Removes the empty header action menu on the main onboarding screen\r\nwhen using the new solution sidenav\r\n* Replaces \"Give feedback\" button on the EDOT collector flow with the\r\nfeedback buttons used in other flows\r\n\r\nOther things mentioned in [the\r\nissue](elastic/observability-dev#4015) have\r\nbeen resolved already by previous changes.\r\n\r\n\r\n\r\n\r\nTo enable the new solution navigation locally:\r\n1. Add these to `kibana.dev.yml`\r\n```\r\nxpack.spaces.allowSolutionVisibility: true\r\nxpack.spaces.experimental.forceSolutionVisibility: true\r\n```\r\n2. Run Kibana and navigate to Spaces Management\r\n3. Set \"Observability\" view for the space you're using locally (most\r\nlikely \"Default\")","sha":"18210933b9250771377293a3005a4cd0277da405","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","v8.16.0"],"title":"[Observability Onboarding] Fix small UI issues","number":197234,"url":"https://github.com/elastic/kibana/pull/197234","mergeCommit":{"message":"[Observability Onboarding] Fix small UI issues (#197234)\n\nCloses elastic/observability-dev#4015 🔒\r\n\r\n* Makes the footer's top boarder to span across the full page width\r\n* Removes the empty header action menu on the main onboarding screen\r\nwhen using the new solution sidenav\r\n* Replaces \"Give feedback\" button on the EDOT collector flow with the\r\nfeedback buttons used in other flows\r\n\r\nOther things mentioned in [the\r\nissue](elastic/observability-dev#4015) have\r\nbeen resolved already by previous changes.\r\n\r\n\r\n\r\n\r\nTo enable the new solution navigation locally:\r\n1. Add these to `kibana.dev.yml`\r\n```\r\nxpack.spaces.allowSolutionVisibility: true\r\nxpack.spaces.experimental.forceSolutionVisibility: true\r\n```\r\n2. Run Kibana and navigate to Spaces Management\r\n3. Set \"Observability\" view for the space you're using locally (most\r\nlikely \"Default\")","sha":"18210933b9250771377293a3005a4cd0277da405"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197234","number":197234,"mergeCommit":{"message":"[Observability Onboarding] Fix small UI issues (#197234)\n\nCloses elastic/observability-dev#4015 🔒\r\n\r\n* Makes the footer's top boarder to span across the full page width\r\n* Removes the empty header action menu on the main onboarding screen\r\nwhen using the new solution sidenav\r\n* Replaces \"Give feedback\" button on the EDOT collector flow with the\r\nfeedback buttons used in other flows\r\n\r\nOther things mentioned in [the\r\nissue](elastic/observability-dev#4015) have\r\nbeen resolved already by previous changes.\r\n\r\n\r\n\r\n\r\nTo enable the new solution navigation locally:\r\n1. Add these to `kibana.dev.yml`\r\n```\r\nxpack.spaces.allowSolutionVisibility: true\r\nxpack.spaces.experimental.forceSolutionVisibility: true\r\n```\r\n2. Run Kibana and navigate to Spaces Management\r\n3. Set \"Observability\" view for the space you're using locally (most\r\nlikely \"Default\")","sha":"18210933b9250771377293a3005a4cd0277da405"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mykola Harmash <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Observability Onboarding] Fix small UI issues (#197234)](#197234) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T16:29:52Z","message":"[Observability Onboarding] Fix small UI issues (#197234)\n\nCloses elastic/observability-dev#4015 🔒\r\n\r\n* Makes the footer's top boarder to span across the full page width\r\n* Removes the empty header action menu on the main onboarding screen\r\nwhen using the new solution sidenav\r\n* Replaces \"Give feedback\" button on the EDOT collector flow with the\r\nfeedback buttons used in other flows\r\n\r\nOther things mentioned in [the\r\nissue](elastic/observability-dev#4015) have\r\nbeen resolved already by previous changes.\r\n\r\n\r\n\r\n\r\nTo enable the new solution navigation locally:\r\n1. Add these to `kibana.dev.yml`\r\n```\r\nxpack.spaces.allowSolutionVisibility: true\r\nxpack.spaces.experimental.forceSolutionVisibility: true\r\n```\r\n2. Run Kibana and navigate to Spaces Management\r\n3. Set \"Observability\" view for the space you're using locally (most\r\nlikely \"Default\")","sha":"18210933b9250771377293a3005a4cd0277da405","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","v8.16.0"],"title":"[Observability Onboarding] Fix small UI issues","number":197234,"url":"https://github.com/elastic/kibana/pull/197234","mergeCommit":{"message":"[Observability Onboarding] Fix small UI issues (#197234)\n\nCloses elastic/observability-dev#4015 🔒\r\n\r\n* Makes the footer's top boarder to span across the full page width\r\n* Removes the empty header action menu on the main onboarding screen\r\nwhen using the new solution sidenav\r\n* Replaces \"Give feedback\" button on the EDOT collector flow with the\r\nfeedback buttons used in other flows\r\n\r\nOther things mentioned in [the\r\nissue](elastic/observability-dev#4015) have\r\nbeen resolved already by previous changes.\r\n\r\n\r\n\r\n\r\nTo enable the new solution navigation locally:\r\n1. Add these to `kibana.dev.yml`\r\n```\r\nxpack.spaces.allowSolutionVisibility: true\r\nxpack.spaces.experimental.forceSolutionVisibility: true\r\n```\r\n2. Run Kibana and navigate to Spaces Management\r\n3. Set \"Observability\" view for the space you're using locally (most\r\nlikely \"Default\")","sha":"18210933b9250771377293a3005a4cd0277da405"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197234","number":197234,"mergeCommit":{"message":"[Observability Onboarding] Fix small UI issues (#197234)\n\nCloses elastic/observability-dev#4015 🔒\r\n\r\n* Makes the footer's top boarder to span across the full page width\r\n* Removes the empty header action menu on the main onboarding screen\r\nwhen using the new solution sidenav\r\n* Replaces \"Give feedback\" button on the EDOT collector flow with the\r\nfeedback buttons used in other flows\r\n\r\nOther things mentioned in [the\r\nissue](elastic/observability-dev#4015) have\r\nbeen resolved already by previous changes.\r\n\r\n\r\n\r\n\r\nTo enable the new solution navigation locally:\r\n1. Add these to `kibana.dev.yml`\r\n```\r\nxpack.spaces.allowSolutionVisibility: true\r\nxpack.spaces.experimental.forceSolutionVisibility: true\r\n```\r\n2. Run Kibana and navigate to Spaces Management\r\n3. Set \"Observability\" view for the space you're using locally (most\r\nlikely \"Default\")","sha":"18210933b9250771377293a3005a4cd0277da405"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mykola Harmash <[email protected]>
@mykolaharmash where you planning to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/observability-dev/issues/4015 🔒
Other things mentioned in the issue have been resolved already by previous changes.
To enable the new solution navigation locally:
kibana.dev.yml