[SecuritySolution][Endpoint] Re-enabled skipped tests #197220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokaditya
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
💚 Build Succeeded
Metrics [docs]
cc @ashokaditya |
joeypoon
approved these changes
Oct 23, 2024
Yes, there's no way to know until this is merged and out in the wild. I couldn't reproduce this and the flaky runner doesn't run unit tests yet. |
|
Starting backport for target branches: 8.x |
This was referenced Oct 23, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2024
## Summary This PR attempts to fix tests skipped in elastic/issues/193092 and elastic/issues/193554. The tests seem to be flaky right after an [upgrade to `user-event`](elastic#189949) dependency on Sep 10th. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit e70b533)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
…#197380) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution][Endpoint] Re-enabled skipped tests (#197220)](#197220) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T08:33:37Z","message":"[SecuritySolution][Endpoint] Re-enabled skipped tests (#197220)\n\n## Summary\r\n\r\nThis PR attempts to fix tests skipped in /issues/193092\r\nand /issues/193554.\r\nThe tests seem to be flaky right after an [upgrade to\r\n`user-event`](#189949) dependency\r\non Sep 10th.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"e70b533bdb443a4ebc8229237583160eeeaad412","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","backport:version","v8.17.0"],"title":"[SecuritySolution][Endpoint] Re-enabled skipped tests","number":197220,"url":"https://github.com/elastic/kibana/pull/197220","mergeCommit":{"message":"[SecuritySolution][Endpoint] Re-enabled skipped tests (#197220)\n\n## Summary\r\n\r\nThis PR attempts to fix tests skipped in /issues/193092\r\nand /issues/193554.\r\nThe tests seem to be flaky right after an [upgrade to\r\n`user-event`](#189949) dependency\r\non Sep 10th.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"e70b533bdb443a4ebc8229237583160eeeaad412"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197220","number":197220,"mergeCommit":{"message":"[SecuritySolution][Endpoint] Re-enabled skipped tests (#197220)\n\n## Summary\r\n\r\nThis PR attempts to fix tests skipped in /issues/193092\r\nand /issues/193554.\r\nThe tests seem to be flaky right after an [upgrade to\r\n`user-event`](#189949) dependency\r\non Sep 10th.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"e70b533bdb443a4ebc8229237583160eeeaad412"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to fix tests skipped in /issues/193092 and /issues/193554.
The tests seem to be flaky right after an upgrade to
user-eventdependency on Sep 10th.Checklist