[ES|QL] Normalize multiplication by one when pretty-printing #197182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimkibana
added
review
release_note:skip
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Page load bundle
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
…#197182) ## Summary Partially addresses elastic#189258 This change will likely supercede elastic#196817 When parsing, currently ES|QL parsers adds extraneous multiply by 1 or multiply by -1 nodes when parsing arithmetic unary expressions. For example, `-(x)` is parsed as `-1 * x`. This change, reverts these when pretty-printing using the `BasicPrettyPrinter`: `-1 * x` is pretty printed as `-x`. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit 848c9f4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stratoula
pushed a commit
that referenced
this pull request
Oct 23, 2024
…197182) (#197318) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Normalize multiplication by one when pretty-printing (#197182)](#197182) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vadim Kibana","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T18:05:09Z","message":"[ES|QL] Normalize multiplication by one when pretty-printing (#197182)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/189258\r\n\r\nThis change will likely supercede\r\nhttps://github.com//pull/196817\r\n\r\nWhen parsing, currently ES|QL parsers adds extraneous multiply by 1 or\r\nmultiply by -1 nodes when parsing arithmetic unary expressions.\r\n\r\nFor example, `-(x)` is parsed as `-1 * x`.\r\n\r\nThis change, reverts these when pretty-printing using the\r\n`BasicPrettyPrinter`: `-1 * x` is pretty printed as `-x`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"848c9f48dc101744c8fae69951916dc511dfdc8a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.17.0"],"title":"[ES|QL] Normalize multiplication by one when pretty-printing","number":197182,"url":"https://github.com/elastic/kibana/pull/197182","mergeCommit":{"message":"[ES|QL] Normalize multiplication by one when pretty-printing (#197182)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/189258\r\n\r\nThis change will likely supercede\r\nhttps://github.com//pull/196817\r\n\r\nWhen parsing, currently ES|QL parsers adds extraneous multiply by 1 or\r\nmultiply by -1 nodes when parsing arithmetic unary expressions.\r\n\r\nFor example, `-(x)` is parsed as `-1 * x`.\r\n\r\nThis change, reverts these when pretty-printing using the\r\n`BasicPrettyPrinter`: `-1 * x` is pretty printed as `-x`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"848c9f48dc101744c8fae69951916dc511dfdc8a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197182","number":197182,"mergeCommit":{"message":"[ES|QL] Normalize multiplication by one when pretty-printing (#197182)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/189258\r\n\r\nThis change will likely supercede\r\nhttps://github.com//pull/196817\r\n\r\nWhen parsing, currently ES|QL parsers adds extraneous multiply by 1 or\r\nmultiply by -1 nodes when parsing arithmetic unary expressions.\r\n\r\nFor example, `-(x)` is parsed as `-1 * x`.\r\n\r\nThis change, reverts these when pretty-printing using the\r\n`BasicPrettyPrinter`: `-1 * x` is pretty printed as `-x`.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)","sha":"848c9f48dc101744c8fae69951916dc511dfdc8a"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Vadim Kibana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #189258
This change will likely supercede #196817
When parsing, currently ES|QL parsers adds extraneous multiply by 1 or multiply by -1 nodes when parsing arithmetic unary expressions.
For example,
-(x)is parsed as-1 * x.This change, reverts these when pretty-printing using the
BasicPrettyPrinter:-1 * xis pretty printed as-x.Checklist
Delete any items that are not applicable to this PR.
For maintainers