-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Enable semantic_text feature in es3 #197140
[Search] Enable semantic_text feature in es3 #197140
Conversation
59a56d1
to
d28331b
Compare
💚 Build Succeeded
Metrics [docs]
|
@saarikabhasi @sphilipse Do we have FTR tests in place for semantic text in serverless? I would have expected them to be enabled with this change. If not do we have an issue for adding them? I assume we have them in stack and we need to ensure they are added to our suite. or they may require some additional work to ensure they are available on the expected page(s). |
@TattdCodeMonkey From what I know we don't have FTR for but we do have good amount of unit tests for adding a new semantic_text . Would it okay if we add FTR in an another PR or do we want them in this PR ? |
No FTRs specifically for semantic text, no. That's still an open issue. |
I think it's ok that we add FTR with another PR(s), I just wanted to call it out that we know we're doing that in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Semantic text feature was disabled by default due to ML node unable to scale down. With the relevant PR & subsequent fix merged, ML node now auto scales when there is no activity. Therefore enabling semantic_text feature in es3.
Testing instructions
semantic_text
is shown in the field type form