Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Enable semantic_text feature in es3 #197140

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

saarikabhasi
Copy link
Member

@saarikabhasi saarikabhasi commented Oct 21, 2024

Summary

Semantic text feature was disabled by default due to ML node unable to scale down. With the relevant PR & subsequent fix merged, ML node now auto scales when there is no activity. Therefore enabling semantic_text feature in es3.

Testing instructions

  • start serverless instance
  • visit index management index details page -> mappings
  • Click Add field
  • Confirm semantic_text is shown in the field type form

@saarikabhasi saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 labels Oct 21, 2024
@saarikabhasi saarikabhasi requested review from a team as code owners October 21, 2024 20:35
@saarikabhasi saarikabhasi added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 21, 2024
@saarikabhasi saarikabhasi force-pushed the es3-enableSemanticText branch 2 times, most recently from 59a56d1 to d28331b Compare October 21, 2024 20:47
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@sphilipse sphilipse added backport:skip This commit does not require backporting v9.0.0 and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Oct 22, 2024
@jloleysens jloleysens added the ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project label Oct 22, 2024
@kc13greiner kc13greiner self-requested a review October 22, 2024 12:30
@TattdCodeMonkey
Copy link
Contributor

@saarikabhasi @sphilipse Do we have FTR tests in place for semantic text in serverless? I would have expected them to be enabled with this change.

If not do we have an issue for adding them? I assume we have them in stack and we need to ensure they are added to our suite. or they may require some additional work to ensure they are available on the expected page(s).

@saarikabhasi
Copy link
Member Author

@TattdCodeMonkey From what I know we don't have FTR for semantic_text yet for serverless & stack. We had this ticket created a while back to have FTRs for serverless & stack and I am not sure if we got around working this. @sphilipse please correct me if I'm wrong

but we do have good amount of unit tests for adding a new semantic_text . Would it okay if we add FTR in an another PR or do we want them in this PR ?

@sphilipse
Copy link
Member

No FTRs specifically for semantic text, no. That's still an open issue.

@TattdCodeMonkey
Copy link
Contributor

Would it okay if we add FTR in an another PR or do we want them in this PR ?

I think it's ok that we add FTR with another PR(s), I just wanted to call it out that we know we're doing that in this case.

Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saarikabhasi saarikabhasi merged commit c25599e into elastic:main Oct 22, 2024
30 checks passed
@saarikabhasi saarikabhasi deleted the es3-enableSemanticText branch January 16, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants