[RCA] Events timeline improvements #197127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benakansara
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
shahzad31
reviewed
Oct 22, 2024
...solution/investigate_app/public/pages/details/components/events_timeline/events_timeline.tsx
Outdated
Show resolved
Hide resolved
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…ages/details/components/events_timeline/events_timeline.tsx Co-authored-by: Shahzad <[email protected]>
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @benakansara |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
Closes elastic#197192 - Alert event is shown as per "alert start" time - Events are filtered by the alert group/source information (For now, only filtering by `service.name` for the demo. We need to change the logic to use `OR` when applying filter for group-by fields) - Fixed rule condition chart on investigation page when "rate" aggregation is used --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Shahzad <[email protected]> (cherry picked from commit 6d7fecd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 22, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[RCA] Events timeline improvements (#197127)](#197127) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T13:24:14Z","message":"[RCA] Events timeline improvements (#197127)\n\nCloses https://github.com/elastic/kibana/issues/197192\r\n\r\n- Alert event is shown as per \"alert start\" time\r\n- Events are filtered by the alert group/source information (For now,\r\nonly filtering by `service.name` for the demo. We need to change the\r\nlogic to use `OR` when applying filter for group-by fields)\r\n- Fixed rule condition chart on investigation page when \"rate\"\r\naggregation is used\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Shahzad <[email protected]>","sha":"6d7fecd8258c60255c3cc1a3d7c86bf1876f62b9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[RCA] Events timeline improvements","number":197127,"url":"https://github.com/elastic/kibana/pull/197127","mergeCommit":{"message":"[RCA] Events timeline improvements (#197127)\n\nCloses https://github.com/elastic/kibana/issues/197192\r\n\r\n- Alert event is shown as per \"alert start\" time\r\n- Events are filtered by the alert group/source information (For now,\r\nonly filtering by `service.name` for the demo. We need to change the\r\nlogic to use `OR` when applying filter for group-by fields)\r\n- Fixed rule condition chart on investigation page when \"rate\"\r\naggregation is used\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Shahzad <[email protected]>","sha":"6d7fecd8258c60255c3cc1a3d7c86bf1876f62b9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197127","number":197127,"mergeCommit":{"message":"[RCA] Events timeline improvements (#197127)\n\nCloses https://github.com/elastic/kibana/issues/197192\r\n\r\n- Alert event is shown as per \"alert start\" time\r\n- Events are filtered by the alert group/source information (For now,\r\nonly filtering by `service.name` for the demo. We need to change the\r\nlogic to use `OR` when applying filter for group-by fields)\r\n- Fixed rule condition chart on investigation page when \"rate\"\r\naggregation is used\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Shahzad <[email protected]>","sha":"6d7fecd8258c60255c3cc1a3d7c86bf1876f62b9"}}]}] BACKPORT--> Co-authored-by: Bena Kansara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197192
service.namefor the demo. We need to change the logic to useORwhen applying filter for group-by fields)