Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/risk summary build columns variable #197059

Merged
merged 9 commits into from
Oct 23, 2024
Merged

Feature/risk summary build columns variable #197059

merged 9 commits into from
Oct 23, 2024
+3 −6

Conversation

CAWilson94
Copy link
Contributor

@CAWilson94 CAWilson94 commented Oct 21, 2024 •
edited
Loading

Summary

This PR removes the re-definition of columns for buildColumns and changes buildColumns to be a static variable as it no longer requires extra functionality of a flag, since asset criticality flag removal.

@CAWilson94 CAWilson94 requested review from a team as code owners October 21, 2024 13:24
@CAWilson94 CAWilson94 requested a review from hop-dev October 21, 2024 13:24
@CAWilson94 CAWilson94 self-assigned this Oct 21, 2024
tiansivive
tiansivive requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@tiansivive tiansivive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just a small request

packages/kbn-ts-projects/ts_project.ts Outdated Show resolved Hide resolved
...ns/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx Outdated Show resolved Hide resolved
@CAWilson94 CAWilson94 added backport:skip This commit does not require backporting Team:Entity Analytics Security Entity Analytics Team labels Oct 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@CAWilson94 CAWilson94 added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@CAWilson94 CAWilson94 added release_note:skip Skip the PR/issue when compiling release notes and removed v9.0.0 v8.16.0 v8.17.0 labels Oct 22, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB -110.0B

History

cc @CAWilson94

@CAWilson94 CAWilson94 merged commit d94bf9a into elastic:main Oct 23, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@tiansivive tiansivive tiansivive approved these changes

@machadoum machadoum machadoum approved these changes

@hop-dev hop-dev Awaiting requested review from hop-dev hop-dev was automatically assigned from elastic/security-entity-analytics

Assignees

@CAWilson94 CAWilson94

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CAWilson94 @elasticmachine @machadoum @tiansivive @Ikuni17 @kibanamachine