-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable stream stats in serverless #197038
Enable stream stats in serverless #197038
Conversation
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]
Historycc @SoniaSanzV |
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Hey @SoniaSanzV, thanks for picking this up! I think additional changes would be needed for this enhancement. If we set |
I completely misunderstood, I thought the API was the same (the name is similar and I wasn't familiar with any of them). I'll continue to work on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to FYI in case this hasn't been tested in QA, you can use the following label ci:project-deploy-elasticsearch
and buildkite will provision a project based on this PR for manually testing in serverless.
Thank you for the info. I changed the status of the PR to Draft because it needs more work. |
As this task has been stopped for quite some time, I think I should give an update on the status. After talking with Elena we saw that maybe you can use this same endpoint in stateful instead of using Example request: GET /_data_stream/*?expand_wildcards=all&verbose Response: {
"error": {
"root_cause": [
{
"type": "security_exception",
"reason": "action [indices:monitor/data_stream/stats] is unauthorized for user [_xpack] with effective roles [_xpack] on restricted indices [.security-7,.security-profile-8], this action is granted by the index privileges [monitor,manage,all]"
}
],
"type": "security_exception",
"reason": "action [indices:monitor/data_stream/stats] is unauthorized for user [_xpack] with effective roles [_xpack] on restricted indices [.security-7,.security-profile-8], this action is granted by the index privileges [monitor,manage,all]"
},
"status": 403
} |
e089bbf
to
f69df81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in config/serverless.yml
and test/plugin_functional/test_suites/core_plugins/rendering.ts
LGTM
Closes #192584
Summary
This PR sets the value of
xpack.index_management.enableDataStreamStats
to true in Serverless. The objective is to display the “Last updated” column in Index Management > Data Streams Table (propety ismaximun_timestamp
). It can be enabled now since the maximum_timestamp property was added to the Get data stream API (see elastic/elasticsearch#112303).On the @elastic/kibana-management side, I've been looking at it carefully and I think only this change in
config/serverless.yml
. The rest of the necessary changes were already incorporated in this PR, testing included.With this change the column is now displayed as expected:
I'm adding
kibana-management
as a reviewer just in case I'm missing something