[FIX ON MKI] x-pack/.../telemetry_config.ts
#197036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
afharo
reviewed
Oct 21, 2024
| @@ -249,6 +249,7 @@ export class CoreAppsService { | |||
| this.configService.setDynamicConfigOverrides(persistedOverrides.attributes); | |||
| latestOverrideVersion = persistedOverrides.version; | |||
| } | |||
| this.logger.info('Succeeded in applying persisted dynamic config overrides'); | |||
There was a problem hiding this comment.
I'd move this log info inside the IF to only log when a change is actually applied. Otherwise, we'll log it every poll-interval.
There was a problem hiding this comment.
oh that makes perfect sense
| import { SupertestWithRoleScopeType } from '@kbn/test-suites-xpack/api_integration/deployment_agnostic/services'; | ||
| import { FtrProviderContext } from '../../../ftr_provider_context'; | ||
|
|
||
| export default function telemetryConfigTest({ getService }: FtrProviderContext) { | ||
| const roleScopedSupertest = getService('roleScopedSupertest'); | ||
| let supertestAdminWithApiKey: SupertestWithRoleScopeType; | ||
| let supertestAdminWithCookieCredentials: SupertestWithRoleScopeType; | ||
| const retry = getService('retry'); | ||
| const retryTimeout = 180 * 1000; |
There was a problem hiding this comment.
IMO, even a shorter timeout would be enough (we poll every 10s). 20s should be plenty.
Ran the typechecker locally. Also ran the tests against local mki and real mki, from my local.
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See details: #197009