[Dataset Quality] Check if Obs Logs Explorer accessible before linking Logs Explorer #197020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awahab07
added
bug
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History |
|
Are we going to backport this to |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
…g Logs Explorer (elastic#197020) Fixes elastic#196506 ## Summary Before linking to Logs Explorer in Dataset Quality, the PR checks if `observability-logs-explorer` is available and accessible before consuming the `SINGLE_DATASET_LOCATOR_ID` locator. Observability Logs Explorer app is not available in Security and Search solution views. After the fix: https://github.com/user-attachments/assets/ed36806a-0483-4765-a6f1-85936b92d390 There's only one more place, Observability Onboarding, where `SINGLE_DATASET_LOCATOR_ID` is consumed. Which being part of Observability solution view, it can be assumed that Observability Logs Explorer will always be available.  ---- The other Observability Logs Explorer locator `ALL_DATASETS_LOCATOR_ID` is only consumed in observability wrapper apps and `apm` and `infra` plugins, all of which are only available under Observability where Observability Logs Explorer is also available. https://github.com/elastic/kibana/blob/68b3267ca2f76d8de4fedef622608d8685e7eceb/packages/deeplinks/observability/locators/observability_logs_explorer.ts#L24 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit c076b7a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 22, 2024
…linking Logs Explorer (#197020) (#197235) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Check if Obs Logs Explorer accessible before linking Logs Explorer (#197020)](#197020) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Abdul Wahab Zahid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T13:09:48Z","message":"[Dataset Quality] Check if Obs Logs Explorer accessible before linking Logs Explorer (#197020)\n\nFixes https://github.com/elastic/kibana/issues/196506\r\n\r\n## Summary\r\n\r\nBefore linking to Logs Explorer in Dataset Quality, the PR checks if\r\n`observability-logs-explorer` is available and accessible before\r\nconsuming the `SINGLE_DATASET_LOCATOR_ID` locator.\r\n\r\nObservability Logs Explorer app is not available in Security and Search\r\nsolution views.\r\n\r\n\r\nAfter the fix:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ed36806a-0483-4765-a6f1-85936b92d390\r\n\r\n\r\n\r\nThere's only one more place, Observability Onboarding, where\r\n`SINGLE_DATASET_LOCATOR_ID` is consumed. Which being part of\r\nObservability solution view, it can be assumed that Observability Logs\r\nExplorer will always be available.\r\n\r\n\r\n\r\n\r\n----\r\n\r\nThe other Observability Logs Explorer locator `ALL_DATASETS_LOCATOR_ID`\r\nis only consumed in observability wrapper apps and `apm` and `infra`\r\nplugins, all of which are only available under Observability where\r\nObservability Logs Explorer is also available.\r\n\r\nhttps://github.com/elastic/kibana/blob/68b3267ca2f76d8de4fedef622608d8685e7eceb/packages/deeplinks/observability/locators/observability_logs_explorer.ts#L24\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c076b7ac45957c2cffb4cbb5f197e8b01a64c8f9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Dataset Quality] Check if Obs Logs Explorer accessible before linking Logs Explorer","number":197020,"url":"https://github.com/elastic/kibana/pull/197020","mergeCommit":{"message":"[Dataset Quality] Check if Obs Logs Explorer accessible before linking Logs Explorer (#197020)\n\nFixes https://github.com/elastic/kibana/issues/196506\r\n\r\n## Summary\r\n\r\nBefore linking to Logs Explorer in Dataset Quality, the PR checks if\r\n`observability-logs-explorer` is available and accessible before\r\nconsuming the `SINGLE_DATASET_LOCATOR_ID` locator.\r\n\r\nObservability Logs Explorer app is not available in Security and Search\r\nsolution views.\r\n\r\n\r\nAfter the fix:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ed36806a-0483-4765-a6f1-85936b92d390\r\n\r\n\r\n\r\nThere's only one more place, Observability Onboarding, where\r\n`SINGLE_DATASET_LOCATOR_ID` is consumed. Which being part of\r\nObservability solution view, it can be assumed that Observability Logs\r\nExplorer will always be available.\r\n\r\n\r\n\r\n\r\n----\r\n\r\nThe other Observability Logs Explorer locator `ALL_DATASETS_LOCATOR_ID`\r\nis only consumed in observability wrapper apps and `apm` and `infra`\r\nplugins, all of which are only available under Observability where\r\nObservability Logs Explorer is also available.\r\n\r\nhttps://github.com/elastic/kibana/blob/68b3267ca2f76d8de4fedef622608d8685e7eceb/packages/deeplinks/observability/locators/observability_logs_explorer.ts#L24\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c076b7ac45957c2cffb4cbb5f197e8b01a64c8f9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197020","number":197020,"mergeCommit":{"message":"[Dataset Quality] Check if Obs Logs Explorer accessible before linking Logs Explorer (#197020)\n\nFixes https://github.com/elastic/kibana/issues/196506\r\n\r\n## Summary\r\n\r\nBefore linking to Logs Explorer in Dataset Quality, the PR checks if\r\n`observability-logs-explorer` is available and accessible before\r\nconsuming the `SINGLE_DATASET_LOCATOR_ID` locator.\r\n\r\nObservability Logs Explorer app is not available in Security and Search\r\nsolution views.\r\n\r\n\r\nAfter the fix:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ed36806a-0483-4765-a6f1-85936b92d390\r\n\r\n\r\n\r\nThere's only one more place, Observability Onboarding, where\r\n`SINGLE_DATASET_LOCATOR_ID` is consumed. Which being part of\r\nObservability solution view, it can be assumed that Observability Logs\r\nExplorer will always be available.\r\n\r\n\r\n\r\n\r\n----\r\n\r\nThe other Observability Logs Explorer locator `ALL_DATASETS_LOCATOR_ID`\r\nis only consumed in observability wrapper apps and `apm` and `infra`\r\nplugins, all of which are only available under Observability where\r\nObservability Logs Explorer is also available.\r\n\r\nhttps://github.com/elastic/kibana/blob/68b3267ca2f76d8de4fedef622608d8685e7eceb/packages/deeplinks/observability/locators/observability_logs_explorer.ts#L24\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c076b7ac45957c2cffb4cbb5f197e8b01a64c8f9"}}]}] BACKPORT--> Co-authored-by: Abdul Wahab Zahid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196506
Summary
Before linking to Logs Explorer in Dataset Quality, the PR checks if
observability-logs-exploreris available and accessible before consuming theSINGLE_DATASET_LOCATOR_IDlocator.Observability Logs Explorer app is not available in Security and Search solution views.
After the fix:
196506-obs-logs-link-broken-security-search.mov
There's only one more place, Observability Onboarding, where
SINGLE_DATASET_LOCATOR_IDis consumed. Which being part of Observability solution view, it can be assumed that Observability Logs Explorer will always be available.The other Observability Logs Explorer locator
ALL_DATASETS_LOCATOR_IDis only consumed in observability wrapper apps andapmandinfraplugins, all of which are only available under Observability where Observability Logs Explorer is also available.kibana/packages/deeplinks/observability/locators/observability_logs_explorer.ts
Line 24 in 68b3267