Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused setup code to connect to remote debugger #196979

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

paulinashakirova
Copy link
Contributor

@paulinashakirova paulinashakirova self-assigned this Oct 19, 2024
@tsullivan
Copy link
Member

  1. We can remove the inspect field from the config schema in packages/kbn-screenshotting-server/src/config/schema.ts
  2. We need to update the unit test should produce correct config for context {"dev": false,"dist": true} in x-pack/plugins/screenshotting/server/config/schema.test.ts by removing the inspect field.
  3. We can remove the line xpack.reporting.capture.browser.chromium.inspect from ./src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker (that would have never worked anyway, since the setting only took effect in dev mode)
  4. The opn import isn't used any more in x-pack/plugins/screenshotting/server/browsers/chromium/driver.ts and it isn't used anywhere else in Kibana :). You can remove the import from the file, remove the opn and @types/opn declarations in package.json.
    1. Once you do this, you need to run yarn kbn bootstrap, which updates yarn.lock. Then you will need to commit the changes to yarn.lock.

@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 21, 2024
@paulinashakirova paulinashakirova marked this pull request as ready for review October 22, 2024 19:05
@paulinashakirova paulinashakirova requested review from a team as code owners October 22, 2024 19:05
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @paulinashakirova

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job on this

@paulinashakirova paulinashakirova merged commit 7d1cffd into main Oct 24, 2024
38 checks passed
@paulinashakirova paulinashakirova deleted the 101233-remove-setup-code-remote-debugger branch October 24, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants