Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page #195773 #196969

Merged
merged 16 commits into from
Oct 29, 2024
Merged

Fix Typo: Change 'dashaboard' to 'dashboard' on APM-service Dashboards page #195773 #196969

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1f48fc8
Fix typo: change 'dashaboard' to 'dashboard' on APM-service Dashboard…
nabeelmohamed Oct 19, 2024
d3e6edf
Merge branch 'main' into main
nabeelmohamed Oct 19, 2024
8a31b92
Merge branch 'main' into main
cauemarcondes Oct 21, 2024
0f2d09e
Merge branch 'main' into main
nabeelmohamed Oct 21, 2024
e37c439
Merge branch 'main' into main
smith Oct 21, 2024
a613d78
Update index.ts
nabeelmohamed Oct 25, 2024
7ce6a0c
Update index.ts in path kibana/src/plugins/saved_objects/public/saved…
nabeelmohamed Oct 25, 2024
f794d5f
Merge branch 'main' into main
nabeelmohamed Oct 25, 2024
726c8fc
Merge branch 'elastic:main' into main
nabeelmohamed Oct 25, 2024
750c9bd
fix: Re-add removed lines in index.ts
nabeelmohamed Oct 25, 2024
bc5f832
Merge branch 'elastic:main' into main
nabeelmohamed Oct 25, 2024
e6d6a0c
re added SavedObjectsclient contract at src/core/public/index.ts
nabeelmohamed Oct 28, 2024
4edc98d
Merge branch 'elastic:main' into main
nabeelmohamed Oct 28, 2024
793d637
Merge branch 'main' into main
jennypavlova Oct 28, 2024
40e18e3
Merge branch 'main' into main
smith Oct 28, 2024
34fa741
Merge branch 'main' into main
jennypavlova Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/core/public/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ export type {
export { CoreScopedHistory } from '@kbn/core-application-browser-internal';

export type {
SavedObjectsClientContract,
Copy link
Contributor

@gsoldevila gsoldevila Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR also removes some exported members from src/core/public/index.ts and src/plugins/saved_objects/public/saved_object/index.ts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cahnges in src/plugins/saved_objects/public/saved_object/index.ts were made to original state by creating new commit instead of revert is it ok @gsoldevila

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's fine, commits are squashed on merge.
The changes in src/core/public/index.ts still need to be reverted though.

SimpleSavedObject,
SavedObjectsCreateOptions,
SavedObjectsDeleteOptions,
Expand Down
2 changes: 0 additions & 2 deletions src/plugins/saved_objects/public/saved_object/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,4 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

export { checkForDuplicateTitle } from './helpers/check_for_duplicate_title';
export { saveWithConfirmation } from './helpers/save_with_confirmation';
export { isErrorNonFatal } from './helpers/save_saved_object';
2 changes: 1 addition & 1 deletion .../observability_solution/apm/public/components/app/service_dashboards/empty_dashboards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function EmptyDashboards({ actions }: Props) {
</ul>
<p>
{i18n.translate('xpack.apm.serviceDashboards.emptyBody.getStarted', {
defaultMessage: 'To get started, add your dashaboard',
defaultMessage: 'To get started, add your dashboard',
})}
</p>
</>
Expand Down