[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models #196939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…covery max alerts for users still using legacy models In consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <elastic#195669> to `100`. This PR also includes additional tests. ## Desk testing 1) Navigate to Security > Attack discovery 2) Click the settings gear 3) Select any value above or below `100` in the Alerts range slider 4) Click `Reset` **Expected result** - The range slider resets to `100`
andrew-goldstein
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
stephmilovic
approved these changes
Oct 18, 2024
💚 Build Succeeded
Metrics [docs]
|
andrew-goldstein
deleted the
updates_default_attack_discovery_max_alerts
branch
|
Starting backport for target branches: 8.16 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…ry max alerts for users still using legacy models (elastic#196939) ### [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models In consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <elastic#195669> to `100`. This PR also includes additional tests. ## Desk testing 1) Navigate to Security > Attack discovery 2) Click the settings gear 3) Select any value above or below `100` in the Alerts range slider 4) Click `Reset` **Expected result** - The range slider resets to `100` (cherry picked from commit 96585a5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…discovery max alerts for users still using legacy models (#196939) (#196959) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939)](#196939) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T21:06:55Z","message":"[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939)\n\n### [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models\r\n\r\nIn consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <#195669> to `100`.\r\n\r\nThis PR also includes additional tests.\r\n\r\n## Desk testing\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Click the settings gear\r\n\r\n3) Select any value above or below `100` in the Alerts range slider\r\n\r\n4) Click `Reset`\r\n\r\n**Expected result**\r\n\r\n- The range slider resets to `100`","sha":"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version"],"title":"[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models","number":196939,"url":"https://github.com/elastic/kibana/pull/196939","mergeCommit":{"message":"[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939)\n\n### [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models\r\n\r\nIn consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <#195669> to `100`.\r\n\r\nThis PR also includes additional tests.\r\n\r\n## Desk testing\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Click the settings gear\r\n\r\n3) Select any value above or below `100` in the Alerts range slider\r\n\r\n4) Click `Reset`\r\n\r\n**Expected result**\r\n\r\n- The range slider resets to `100`","sha":"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196939","number":196939,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939)\n\n### [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models\r\n\r\nIn consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <#195669> to `100`.\r\n\r\nThis PR also includes additional tests.\r\n\r\n## Desk testing\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Click the settings gear\r\n\r\n3) Select any value above or below `100` in the Alerts range slider\r\n\r\n4) Click `Reset`\r\n\r\n**Expected result**\r\n\r\n- The range slider resets to `100`","sha":"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Andrew Macri <[email protected]>
|
@andrew-goldstein there's a version gap with this backport. Can you check if this should also be backported to 8.x/8.17? |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Oct 24, 2024
…ry max alerts for users still using legacy models (elastic#196939) ### [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models In consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <elastic#195669> to `100`. This PR also includes additional tests. ## Desk testing 1) Navigate to Security > Attack discovery 2) Click the settings gear 3) Select any value above or below `100` in the Alerts range slider 4) Click `Reset` **Expected result** - The range slider resets to `100` (cherry picked from commit 96585a5)
andrew-goldstein
added a commit
that referenced
this pull request
Oct 24, 2024
…iscovery max alerts for users still using legacy models (#196939) (#197554) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939)](#196939) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Andrew Macri","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T21:06:55Z","message":"[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939)\n\n### [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models\r\n\r\nIn consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <#195669> to `100`.\r\n\r\nThis PR also includes additional tests.\r\n\r\n## Desk testing\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Click the settings gear\r\n\r\n3) Select any value above or below `100` in the Alerts range slider\r\n\r\n4) Click `Reset`\r\n\r\n**Expected result**\r\n\r\n- The range slider resets to `100`","sha":"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version"],"number":196939,"url":"https://github.com/elastic/kibana/pull/196939","mergeCommit":{"message":"[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939)\n\n### [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models\r\n\r\nIn consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <#195669> to `100`.\r\n\r\nThis PR also includes additional tests.\r\n\r\n## Desk testing\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Click the settings gear\r\n\r\n3) Select any value above or below `100` in the Alerts range slider\r\n\r\n4) Click `Reset`\r\n\r\n**Expected result**\r\n\r\n- The range slider resets to `100`","sha":"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196939","number":196939,"mergeCommit":{"message":"[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939)\n\n### [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models\r\n\r\nIn consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates `DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in <#195669> to `100`.\r\n\r\nThis PR also includes additional tests.\r\n\r\n## Desk testing\r\n\r\n1) Navigate to Security > Attack discovery\r\n\r\n2) Click the settings gear\r\n\r\n3) Select any value above or below `100` in the Alerts range slider\r\n\r\n4) Click `Reset`\r\n\r\n**Expected result**\r\n\r\n- The range slider resets to `100`","sha":"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196959","number":196959,"state":"MERGED","mergeCommit":{"sha":"b80bc6235d28d0ff88b8defa80754e26a65169b5","message":"[8.16] [Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models (#196939) (#196959)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[Security Solution] [Attack discovery] Updates default Attack\ndiscovery max alerts for users still using legacy models\n(#196939)](https://github.com/elastic/kibana/pull/196939)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Andrew\nMacri\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-18T21:06:55Z\",\"message\":\"[Security\nSolution] [Attack discovery] Updates default Attack discovery max alerts\nfor users still using legacy models (#196939)\\n\\n### [Security Solution]\n[Attack discovery] Updates default Attack discovery max alerts for users\nstill using legacy models\\r\\n\\r\\nIn consideration of users still using\nlegacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates\n`DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in\n<#195669> to `100`.\\r\\n\\r\\nThis PR\nalso includes additional tests.\\r\\n\\r\\n## Desk testing\\r\\n\\r\\n1)\nNavigate to Security > Attack discovery\\r\\n\\r\\n2) Click the settings\ngear\\r\\n\\r\\n3) Select any value above or below `100` in the Alerts range\nslider\\r\\n\\r\\n4) Click `Reset`\\r\\n\\r\\n**Expected result**\\r\\n\\r\\n- The\nrange slider resets to\n`100`\",\"sha\":\"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:\nSecuritySolution\",\"Team:Security Generative\nAI\",\"v8.16.0\",\"backport:version\"],\"title\":\"[Security Solution] [Attack\ndiscovery] Updates default Attack discovery max alerts for users still\nusing legacy\nmodels\",\"number\":196939,\"url\":\"https://github.com/elastic/kibana/pull/196939\",\"mergeCommit\":{\"message\":\"[Security\nSolution] [Attack discovery] Updates default Attack discovery max alerts\nfor users still using legacy models (#196939)\\n\\n### [Security Solution]\n[Attack discovery] Updates default Attack discovery max alerts for users\nstill using legacy models\\r\\n\\r\\nIn consideration of users still using\nlegacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates\n`DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in\n<#195669> to `100`.\\r\\n\\r\\nThis PR\nalso includes additional tests.\\r\\n\\r\\n## Desk testing\\r\\n\\r\\n1)\nNavigate to Security > Attack discovery\\r\\n\\r\\n2) Click the settings\ngear\\r\\n\\r\\n3) Select any value above or below `100` in the Alerts range\nslider\\r\\n\\r\\n4) Click `Reset`\\r\\n\\r\\n**Expected result**\\r\\n\\r\\n- The\nrange slider resets to\n`100`\",\"sha\":\"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196939\",\"number\":196939,\"mergeCommit\":{\"message\":\"[Security\nSolution] [Attack discovery] Updates default Attack discovery max alerts\nfor users still using legacy models (#196939)\\n\\n### [Security Solution]\n[Attack discovery] Updates default Attack discovery max alerts for users\nstill using legacy models\\r\\n\\r\\nIn consideration of users still using\nlegacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates\n`DEFAULT_ATTACK_DISCOVERY_MAX_ALERTS` from its previous value `200` in\n<#195669> to `100`.\\r\\n\\r\\nThis PR\nalso includes additional tests.\\r\\n\\r\\n## Desk testing\\r\\n\\r\\n1)\nNavigate to Security > Attack discovery\\r\\n\\r\\n2) Click the settings\ngear\\r\\n\\r\\n3) Select any value above or below `100` in the Alerts range\nslider\\r\\n\\r\\n4) Click `Reset`\\r\\n\\r\\n**Expected result**\\r\\n\\r\\n- The\nrange slider resets to\n`100`\",\"sha\":\"96585a540b2c5c717ecaf1f71cc2f6f69b4378f5\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Andrew Macri <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Security Solution] [Attack discovery] Updates default Attack discovery max alerts for users still using legacy models
In consideration of users still using legacy models, (e.g. GPT-4 instead of GPT-4o), this PR updates
DEFAULT_ATTACK_DISCOVERY_MAX_ALERTSfrom its previous value200in #195669 to100.This PR also includes additional tests.
Desk testing
Navigate to Security > Attack discovery
Click the settings gear
Select any value above or below
100in the Alerts range sliderClick
ResetExpected result
100