[Spaces Mgmt] Ensure space ID is used for comparison logic #196930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
|
Starting backport for target branches: 8.16, 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
…96930) Closes elastic#192811 ## Summary When creating a space, if it's not the current, you should be able to use the switch icon from the table. This PR fixes a bug that disabled the switch icon for spaces that aren't the current, if they have the same name as the current. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a3d216f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
…96930) Closes elastic#192811 ## Summary When creating a space, if it's not the current, you should be able to use the switch icon from the table. This PR fixes a bug that disabled the switch icon for spaces that aren't the current, if they have the same name as the current. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a3d216f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…96930) (#197135) # Backport This will backport the following commits from `main` to `8.16`: - [[Spaces Mgmt] Ensure space ID is used for comparison logic (#196930)](#196930) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T20:15:13Z","message":"[Spaces Mgmt] Ensure space ID is used for comparison logic (#196930)\n\nCloses https://github.com/elastic/kibana/issues/192811\r\n\r\n## Summary\r\n\r\nWhen creating a space, if it's not the current, you should be able to\r\nuse the switch icon from the table. This PR fixes a bug that disabled\r\nthe switch icon for spaces that aren't the current, if they have the\r\nsame name as the current.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a3d216f496d319ab41855711e88c4b9c80a57152","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[Spaces Mgmt] Ensure space ID is used for comparison logic","number":196930,"url":"https://github.com/elastic/kibana/pull/196930","mergeCommit":{"message":"[Spaces Mgmt] Ensure space ID is used for comparison logic (#196930)\n\nCloses https://github.com/elastic/kibana/issues/192811\r\n\r\n## Summary\r\n\r\nWhen creating a space, if it's not the current, you should be able to\r\nuse the switch icon from the table. This PR fixes a bug that disabled\r\nthe switch icon for spaces that aren't the current, if they have the\r\nsame name as the current.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a3d216f496d319ab41855711e88c4b9c80a57152"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196930","number":196930,"mergeCommit":{"message":"[Spaces Mgmt] Ensure space ID is used for comparison logic (#196930)\n\nCloses https://github.com/elastic/kibana/issues/192811\r\n\r\n## Summary\r\n\r\nWhen creating a space, if it's not the current, you should be able to\r\nuse the switch icon from the table. This PR fixes a bug that disabled\r\nthe switch icon for spaces that aren't the current, if they have the\r\nsame name as the current.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a3d216f496d319ab41855711e88c4b9c80a57152"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tim Sullivan <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…6930) (#197136) # Backport This will backport the following commits from `main` to `8.x`: - [[Spaces Mgmt] Ensure space ID is used for comparison logic (#196930)](#196930) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T20:15:13Z","message":"[Spaces Mgmt] Ensure space ID is used for comparison logic (#196930)\n\nCloses https://github.com/elastic/kibana/issues/192811\r\n\r\n## Summary\r\n\r\nWhen creating a space, if it's not the current, you should be able to\r\nuse the switch icon from the table. This PR fixes a bug that disabled\r\nthe switch icon for spaces that aren't the current, if they have the\r\nsame name as the current.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a3d216f496d319ab41855711e88c4b9c80a57152","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[Spaces Mgmt] Ensure space ID is used for comparison logic","number":196930,"url":"https://github.com/elastic/kibana/pull/196930","mergeCommit":{"message":"[Spaces Mgmt] Ensure space ID is used for comparison logic (#196930)\n\nCloses https://github.com/elastic/kibana/issues/192811\r\n\r\n## Summary\r\n\r\nWhen creating a space, if it's not the current, you should be able to\r\nuse the switch icon from the table. This PR fixes a bug that disabled\r\nthe switch icon for spaces that aren't the current, if they have the\r\nsame name as the current.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a3d216f496d319ab41855711e88c4b9c80a57152"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196930","number":196930,"mergeCommit":{"message":"[Spaces Mgmt] Ensure space ID is used for comparison logic (#196930)\n\nCloses https://github.com/elastic/kibana/issues/192811\r\n\r\n## Summary\r\n\r\nWhen creating a space, if it's not the current, you should be able to\r\nuse the switch icon from the table. This PR fixes a bug that disabled\r\nthe switch icon for spaces that aren't the current, if they have the\r\nsame name as the current.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a3d216f496d319ab41855711e88c4b9c80a57152"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tim Sullivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192811
Summary
When creating a space, if it's not the current, you should be able to use the switch icon from the table. This PR fixes a bug that disabled the switch icon for spaces that aren't the current, if they have the same name as the current.
Checklist
Delete any items that are not applicable to this PR.