Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Search][Serverless] Enabled Onboarding without Feature Flag (#196755) #196929

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

TattdCodeMonkey
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…#196755)

## Summary

This PR removes the feature flag check for the new search onboarding
experience in Serverless.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit e955cb0)

# Conflicts:
#	x-pack/plugins/serverless_search/public/navigation_tree.ts
#	x-pack/test_serverless/functional/test_suites/search/index.ts
#	x-pack/test_serverless/functional/test_suites/search/navigation.ts
@TattdCodeMonkey
Copy link
Contributor Author

For reference the serverless and serverless FTR changes aren't really need in this backport, but the related changes to search_indices are. And since those are both likely to continue to change together I included them in the backport to make any future backports for search_indices easier.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchIndices 223 222 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
searchIndices 19 18 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchIndices 7.3KB 7.1KB -170.0B
serverlessSearch 21.5KB 21.5KB +51.0B
total -119.0B
Unknown metric groups

API count

id before after diff
searchIndices 19 18 -1

@TattdCodeMonkey TattdCodeMonkey merged commit 1f4532a into elastic:8.x Oct 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants