Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Fleet] unskip flaky test (#196806) #196907

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[8.x] [Fleet] unskip flaky test (#196806) #196907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...icy/components/agent_policy_advanced_fields/custom_fields/global_data_tags_table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ const TEST_IDS = {
VALUE_INPUT: 'globalDataTagsValueInput',
};

// Failing: See https://github.com/elastic/kibana/issues/192798
describe.skip('GlobalDataTagsTable', () => {
describe('GlobalDataTagsTable', () => {
let renderResult: RenderResult;
let mockUpdateAgentPolicy: jest.Mock;
const globalDataTags: GlobalDataTag[] = [
Expand All @@ -49,8 +48,7 @@ describe.skip('GlobalDataTagsTable', () => {
React.ComponentProps<typeof GlobalDataTagsTable>['updateAgentPolicy']
>((policy) => {
mockUpdateAgentPolicy(policy);
// @ts-expect-error - TODO: fix this, types do not match
_updateAgentPolicy(policy);
_updateAgentPolicy({ ...policy, global_data_tags: policy.global_data_tags ?? [] });
}, []);

return (
Expand Down Expand Up @@ -127,7 +125,7 @@ describe.skip('GlobalDataTagsTable', () => {
{ name: 'newTag2', value: '123 123' },
],
});
});
}, 10000);

it('should edit an existing tag', async () => {
renderComponent(globalDataTags);
Expand Down
12 changes: 3 additions & 9 deletions .../fleet/sections/agent_policy/create_package_policy_page/single_page_layout/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,7 @@ afterAll(() => {
consoleDebugMock.mockRestore();
});

// FLAKY: https://github.com/elastic/kibana/issues/196463
// FLAKY: https://github.com/elastic/kibana/issues/196464
// FLAKY: https://github.com/elastic/kibana/issues/196465
// FLAKY: https://github.com/elastic/kibana/issues/196466
// FLAKY: https://github.com/elastic/kibana/issues/196467
// FLAKY: https://github.com/elastic/kibana/issues/196468
// FLAKY: https://github.com/elastic/kibana/issues/196469
describe.skip('When on the package policy create page', () => {
describe('When on the package policy create page', () => {
afterEach(() => {
jest.clearAllMocks();
});
Expand Down Expand Up @@ -212,6 +205,7 @@ describe.skip('When on the package policy create page', () => {
data_streams: [
{
type: 'logs',
name: 'access logs',
dataset: 'nginx.access',
title: 'Nginx access logs',
ingest_pipeline: 'default',
Expand Down Expand Up @@ -306,7 +300,7 @@ describe.skip('When on the package policy create page', () => {
test('should use custom "cancel" URL', () => {
expect(cancelLink.href).toBe(expectedRouteState.onCancelUrl);
expect(cancelButton.href).toBe(expectedRouteState.onCancelUrl);
});
}, 10000);
});
});

Expand Down
5 changes: 2 additions & 3 deletions x-pack/plugins/fleet/public/components/manage_agent_policies_modal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ jest.mock('../hooks', () => ({
}),
}));

// FLAKY: https://github.com/elastic/kibana/issues/189004
describe.skip('ManageAgentPoliciesModal', () => {
describe('ManageAgentPoliciesModal', () => {
let testRenderer: TestRenderer;
const mockOnClose = jest.fn();
const mockPolicies = [{ name: 'Test policy', revision: 2, id: 'policy1' }] as AgentPolicy[];
Expand Down Expand Up @@ -115,7 +114,7 @@ describe.skip('ManageAgentPoliciesModal', () => {
expect(usePackagePolicyWithRelatedData('', {}).savePackagePolicy).toHaveBeenCalledWith({
policy_ids: ['policy1', 'policy2'],
});
});
}, 10000);

it('should keep managed policy when policies are changed', async () => {
(useGetAgentPolicies as jest.Mock).mockReturnValue({
Expand Down
Loading