Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Screenshotting/PDF Worker Thread] Add type to GeneratePdfResponse #196860

Merged
merged 2 commits into from
Oct 21, 2024
Merged

[Screenshotting/PDF Worker Thread] Add type to GeneratePdfResponse #196860

merged 2 commits into from
Oct 21, 2024

Conversation

kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Oct 18, 2024 •
edited by kibanamachine
Loading

Summary

This PR adds a type to GeneratePdfResponse and introduces more logging for PDF worker.

Closes: #194493

@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export labels Oct 18, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Oct 18, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof marked this pull request as ready for review October 21, 2024 08:11
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner October 21, 2024 08:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

tsullivan
tsullivan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I pulled the code and testing PDF export a few different times. Now, have debug logs from the PDF worker, this is great!

I also tested the error handling abilities by manually adding error throwing in to the worker, and those are caught as expected.

@tsullivan tsullivan added v8.16.0 backport:version Backport to applied version labels v8.17.0 and removed backport:skip This commit does not require backporting labels Oct 21, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof merged commit c25a97b into elastic:main Oct 21, 2024
34 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11447049212

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2024
@kowalczyk-krzysztof
[Screenshotting/PDF Worker Thread] Add type to GeneratePdfResponse (e…
82eeb77 
…lastic#196860)

## Summary

This PR adds a `type` to `GeneratePdfResponse` and introduces more
logging for PDF worker.

Closes: elastic#194493
(cherry picked from commit c25a97b)
@kibanamachine kibanamachine mentioned this pull request Oct 21, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2024
@kowalczyk-krzysztof
[Screenshotting/PDF Worker Thread] Add type to GeneratePdfResponse (e…
be8bc45 
…lastic#196860)

## Summary

This PR adds a `type` to `GeneratePdfResponse` and introduces more
logging for PDF worker.

Closes: elastic#194493
(cherry picked from commit c25a97b)
@kibanamachine kibanamachine mentioned this pull request Oct 21, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 21, 2024
@kibanamachine @kowalczyk-krzysztof
[8.16] [Screenshotting/PDF Worker Thread] Add type to GeneratePdfResp…
494164e 
…onse (#196860) (#197128)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Screenshotting/PDF Worker Thread] Add type to GeneratePdfResponse
(#196860)](#196860)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T19:15:58Z","message":"[Screenshotting/PDF
Worker Thread] Add type to GeneratePdfResponse (#196860)\n\n##
Summary\r\n\r\nThis PR adds a `type` to `GeneratePdfResponse` and
introduces more\r\nlogging for PDF worker.\r\n\r\nCloses:
#194493","sha":"c25a97bc0a3a85ad5c7bb18aab7916410efd05b7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","v8.16.0","Feature:Reporting:Screenshot","backport:version","v8.17.0"],"title":"[Screenshotting/PDF
Worker Thread] Add type to
GeneratePdfResponse","number":196860,"url":"https://github.com/elastic/kibana/pull/196860","mergeCommit":{"message":"[Screenshotting/PDF
Worker Thread] Add type to GeneratePdfResponse (#196860)\n\n##
Summary\r\n\r\nThis PR adds a `type` to `GeneratePdfResponse` and
introduces more\r\nlogging for PDF worker.\r\n\r\nCloses:
#194493","sha":"c25a97bc0a3a85ad5c7bb18aab7916410efd05b7"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196860","number":196860,"mergeCommit":{"message":"[Screenshotting/PDF
Worker Thread] Add type to GeneratePdfResponse (#196860)\n\n##
Summary\r\n\r\nThis PR adds a `type` to `GeneratePdfResponse` and
introduces more\r\nlogging for PDF worker.\r\n\r\nCloses:
#194493","sha":"c25a97bc0a3a85ad5c7bb18aab7916410efd05b7"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 21, 2024
@kibanamachine @kowalczyk-krzysztof
[8.x] [Screenshotting/PDF Worker Thread] Add type to GeneratePdfRespo…
149081a 
…nse (#196860) (#197129)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Screenshotting/PDF Worker Thread] Add type to GeneratePdfResponse
(#196860)](#196860)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T19:15:58Z","message":"[Screenshotting/PDF
Worker Thread] Add type to GeneratePdfResponse (#196860)\n\n##
Summary\r\n\r\nThis PR adds a `type` to `GeneratePdfResponse` and
introduces more\r\nlogging for PDF worker.\r\n\r\nCloses:
#194493","sha":"c25a97bc0a3a85ad5c7bb18aab7916410efd05b7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","v8.16.0","Feature:Reporting:Screenshot","backport:version","v8.17.0"],"title":"[Screenshotting/PDF
Worker Thread] Add type to
GeneratePdfResponse","number":196860,"url":"https://github.com/elastic/kibana/pull/196860","mergeCommit":{"message":"[Screenshotting/PDF
Worker Thread] Add type to GeneratePdfResponse (#196860)\n\n##
Summary\r\n\r\nThis PR adds a `type` to `GeneratePdfResponse` and
introduces more\r\nlogging for PDF worker.\r\n\r\nCloses:
#194493","sha":"c25a97bc0a3a85ad5c7bb18aab7916410efd05b7"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196860","number":196860,"mergeCommit":{"message":"[Screenshotting/PDF
Worker Thread] Add type to GeneratePdfResponse (#196860)\n\n##
Summary\r\n\r\nThis PR adds a `type` to `GeneratePdfResponse` and
introduces more\r\nlogging for PDF worker.\r\n\r\nCloses:
#194493","sha":"c25a97bc0a3a85ad5c7bb18aab7916410efd05b7"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels
backport:version Backport to applied version labels Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Screenshotting/PDF Worker Thread] send log messages from the worker to the main thread
4 participants
@kowalczyk-krzysztof @elasticmachine @kibanamachine @tsullivan