Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Authz] Enabled no_deprecated_authz_config for migration only #196852

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

elena-shostak
Copy link
Contributor

@elena-shostak elena-shostak commented Oct 18, 2024

Summary

To ensure that no_deprecated_authz_config rule is only applied during an intentional migration, added check for env vars presence.

If neither MIGRATE_ENABLED_AUTHZ nor MIGRATE_DISABLED_AUTHZ is set, the rule will be skipped, avoiding unnecessary or unforeseen code changes both locally and in the CI.

Added fix and test case for access:${APP.TEST_ID} tags that have property access in the template literal.

Closes: #196846

Checklist

@elena-shostak elena-shostak marked this pull request as ready for review October 20, 2024 12:36
@elena-shostak elena-shostak requested a review from a team as a code owner October 20, 2024 12:36
@elena-shostak elena-shostak added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Oct 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elena-shostak elena-shostak added Feature:Security/Authorization Platform Security - Authorization backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Oct 20, 2024
@elena-shostak
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@elena-shostak elena-shostak merged commit 5ffe226 into elastic:main Oct 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Security/Authorization Platform Security - Authorization release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Authz] Enable no_deprecated_authz_config rule
4 participants