Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ES|QL] Fix trailing decimals dropped from client side validation messages (#196570) #196752

Merged
merged 1 commit into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ describe('function validation', () => {
// date
await expectErrors('FROM a_index | EVAL TEST(NOW())', []);
await expectErrors('FROM a_index | EVAL TEST(1.)', [
'Argument of [test] must be [date], found value [1] type [decimal]',
'Argument of [test] must be [date], found value [1.] type [decimal]',
]);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function validateFunctionLiteralArg(
values: {
name: astFunction.name,
argType: argDef.type as string,
value: typeof actualArg.value === 'number' ? actualArg.value : String(actualArg.value),
value: actualArg.text,
givenType: actualArg.literalType,
},
locations: actualArg.location,
Expand Down